racktables
12 years agor2021 + fix IPv4 address bypass arg handling
Denis Ovsienko [Tue, 1 Jul 2008 18:07:56 +0000 (18:07 +0000)] 
r2021 + fix IPv4 address bypass arg handling
+ add "release" button to properties tab

12 years agor2020 + implement RS pools binder for object page
Denis Ovsienko [Tue, 1 Jul 2008 14:35:08 +0000 (14:35 +0000)] 
r2020 + implement RS pools binder for object page

12 years agor2019 + implement RS pool edit tab
Denis Ovsienko [Tue, 1 Jul 2008 13:05:20 +0000 (13:05 +0000)] 
r2019 + implement RS pool edit tab

12 years agor2018 + change "rspool" to "ipv4rsp"
Denis Ovsienko [Tue, 1 Jul 2008 12:38:51 +0000 (12:38 +0000)] 
r2018 + change "rspool" to "ipv4rsp"
+ change automatic tags names a little

12 years agor2017 + change VS bypass arg name to "vs_id"
Denis Ovsienko [Tue, 1 Jul 2008 01:18:00 +0000 (01:18 +0000)] 
r2017 + change VS bypass arg name to "vs_id"
+ implement own LB editor for virtual service page

12 years agor2016 + hide tag filter mode input, because it's not working as expected
Denis Ovsienko [Tue, 1 Jul 2008 00:04:48 +0000 (00:04 +0000)] 
r2016 + hide tag filter mode input, because it's not working as expected

12 years agor2015 + output more user-friendly error messages on LiveVLANs tab
Denis Ovsienko [Mon, 30 Jun 2008 23:44:04 +0000 (23:44 +0000)] 
r2015 + output more user-friendly error messages on LiveVLANs tab

12 years agor2014 + renderRackMultiSelect(): employ OPTGROUP for better rack listing
Denis Ovsienko [Mon, 30 Jun 2008 22:44:20 +0000 (22:44 +0000)] 
r2014 + renderRackMultiSelect(): employ OPTGROUP for better rack listing

12 years agor2013 + implemented "Edit" tab for virtual service page
Denis Ovsienko [Mon, 30 Jun 2008 21:22:05 +0000 (21:22 +0000)] 
r2013 + implemented "Edit" tab for virtual service page

12 years agor2012 + change 'vservice' to 'ipv4vs'
Denis Ovsienko [Mon, 30 Jun 2008 20:40:25 +0000 (20:40 +0000)] 
r2012 + change 'vservice' to 'ipv4vs'
+ reflect recent page name changes in upgrade.php

12 years agor2011 + enforce left alignment in RS pool list
Denis Ovsienko [Mon, 30 Jun 2008 15:45:32 +0000 (15:45 +0000)] 
r2011 + enforce left alignment in RS pool list

12 years agor2010 + change 'rspools' to 'ipv4rsplist'
Denis Ovsienko [Mon, 30 Jun 2008 15:42:45 +0000 (15:42 +0000)] 
r2010 + change 'rspools' to 'ipv4rsplist'
+ only show "manage" portlets when applicable

12 years agor2009 + change "vservices" to "ipv4vslist"
Denis Ovsienko [Mon, 30 Jun 2008 15:29:26 +0000 (15:29 +0000)] 
r2009 + change "vservices" to "ipv4vslist"
+ add VS counters
+ minor fixes

12 years agor2008 + fix column alignment; improve iteration readability
Denis Ovsienko [Mon, 30 Jun 2008 14:52:18 +0000 (14:52 +0000)] 
r2008 + fix column alignment; improve iteration readability

12 years agor2007 + keep some tab triggers profiling code around
Denis Ovsienko [Fri, 27 Jun 2008 14:19:18 +0000 (14:19 +0000)] 
r2007 + keep some tab triggers profiling code around

12 years agor2006 + handle WS-C2950T-48
Denis Ovsienko [Fri, 27 Jun 2008 14:09:42 +0000 (14:09 +0000)] 
r2006 + handle WS-C2950T-48
+ show existing tags counter in tag editor selector

12 years agor2005 + fix objectIsPortless()
Denis Ovsienko [Thu, 26 Jun 2008 17:15:19 +0000 (17:15 +0000)] 
r2005 + fix objectIsPortless()
+ go on with debugging of changeset:2003

12 years agor2004 + introduce getNarrowObjectList() and use it for drop-down lists instead of...
Denis Ovsienko [Thu, 26 Jun 2008 15:59:23 +0000 (15:59 +0000)] 
r2004 + introduce getNarrowObjectList() and use it for drop-down lists instead of more heavy getObjectList()

12 years agor2003 + implement tag filter feature
Denis Ovsienko [Thu, 26 Jun 2008 00:01:04 +0000 (00:01 +0000)] 
r2003 + implement tag filter feature

12 years agor2002 + update RackCode parser to match the current language definition
Denis Ovsienko [Wed, 25 Jun 2008 19:12:21 +0000 (19:12 +0000)] 
r2002 + update RackCode parser to match the current language definition

12 years agor2001 + finally stick with "tag chain" term
Denis Ovsienko [Wed, 25 Jun 2008 18:40:20 +0000 (18:40 +0000)] 
r2001 + finally stick with "tag chain" term

12 years agor2000 + improve the semantic filter: include the problematic predicate name in error...
Denis Ovsienko [Wed, 25 Jun 2008 15:21:02 +0000 (15:21 +0000)] 
r2000 + improve the semantic filter: include the problematic predicate name in error message

12 years agor1999 + fix mbstring init
Denis Ovsienko [Wed, 25 Jun 2008 14:35:12 +0000 (14:35 +0000)] 
r1999 + fix mbstring init
+ adjust tag name regexp and make it a symbolic constant

12 years agor1998 + generate CN autotag for objects, where possible
Denis Ovsienko [Wed, 25 Jun 2008 12:23:51 +0000 (12:23 +0000)] 
r1998 + generate CN autotag for objects, where possible

12 years agor1997 + introduce validTagName() and use it for filtering
Denis Ovsienko [Wed, 25 Jun 2008 12:07:56 +0000 (12:07 +0000)] 
r1997 + introduce validTagName() and use it for filtering

12 years agor1996 + fix typo
Denis Ovsienko [Tue, 24 Jun 2008 20:13:47 +0000 (20:13 +0000)] 
r1996 + fix typo

12 years agor1995 + rearrange code to handle 0.16 upgrades better
Denis Ovsienko [Tue, 24 Jun 2008 20:12:06 +0000 (20:12 +0000)] 
r1995 + rearrange code to handle 0.16 upgrades better

12 years agor1994 + rework RackCode parsing error handling to avoid premature script termination
Denis Ovsienko [Mon, 23 Jun 2008 22:49:28 +0000 (22:49 +0000)] 
r1994 + rework RackCode parsing error handling to avoid premature script termination

12 years agor1993 + mention the multibyte string extension
Denis Ovsienko [Mon, 23 Jun 2008 22:45:30 +0000 (22:45 +0000)] 
r1993 + mention the multibyte string extension

12 years agor1992 + switchvlans and slbconfig gateways now rely on the higher-level RackCode...
Denis Ovsienko [Mon, 23 Jun 2008 12:45:43 +0000 (12:45 +0000)] 
r1992 + switchvlans and slbconfig gateways now rely on the higher-level RackCode authorization

12 years agor1991 + user accounts are now searchable by username
Denis Ovsienko [Mon, 23 Jun 2008 11:41:40 +0000 (11:41 +0000)] 
r1991 + user accounts are now searchable by username

12 years agor1990 + introduce objectIsPortless() to greatly save on two expensive SQL queries
Denis Ovsienko [Thu, 19 Jun 2008 18:05:58 +0000 (18:05 +0000)] 
r1990 + introduce objectIsPortless() to greatly save on two expensive SQL queries

12 years agor1989 + mergeSearchResults(): sort search results on SQL server side
Denis Ovsienko [Thu, 19 Jun 2008 17:46:46 +0000 (17:46 +0000)] 
r1989 + mergeSearchResults(): sort search results on SQL server side

12 years agor1988 + adjust tab renaming
Denis Ovsienko [Thu, 19 Jun 2008 16:38:23 +0000 (16:38 +0000)] 
r1988 + adjust tab renaming

12 years agor1987 + make RackCode textare taller
Denis Ovsienko [Thu, 19 Jun 2008 16:36:12 +0000 (16:36 +0000)] 
r1987 + make RackCode textare taller

12 years agor1986 + support multibyte tags
Denis Ovsienko [Thu, 19 Jun 2008 11:53:54 +0000 (11:53 +0000)] 
r1986 + support multibyte tags

12 years agor1985 + rename switchvlans to livevlans
Denis Ovsienko [Thu, 19 Jun 2008 10:19:00 +0000 (10:19 +0000)] 
r1985 + rename switchvlans to livevlans
+ improve redirection functions once more
+ introduce multiline logging across redirects
+ move VLAN reconfiguration code from form rendering function to own ophandler
+ start testing the "delayed" authorization for multi-op handlers

12 years agor1984 + fix search to use the correct authz check
Denis Ovsienko [Wed, 18 Jun 2008 10:14:50 +0000 (10:14 +0000)] 
r1984 + fix search to use the correct authz check

12 years agor1983 + fix boolean constants validation and evaluation
Denis Ovsienko [Wed, 18 Jun 2008 09:42:58 +0000 (09:42 +0000)] 
r1983 + fix boolean constants validation and evaluation
+ add calling function name to showError() calls
+ filter out CRs from RackCode and add trailing LF

12 years agor1982 + fix UserPermission to RackCode conversion, it was somewhat broken
Denis Ovsienko [Wed, 18 Jun 2008 09:40:15 +0000 (09:40 +0000)] 
r1982 + fix UserPermission to RackCode conversion, it was somewhat broken

12 years agor1981 + fix authz mean for sub-pages and tabs
Denis Ovsienko [Tue, 17 Jun 2008 18:03:58 +0000 (18:03 +0000)] 
r1981 + fix authz mean for sub-pages and tabs

12 years agor1980 + lots of adjustments to fit the new RackCode authorization framework
Denis Ovsienko [Tue, 17 Jun 2008 17:47:16 +0000 (17:47 +0000)] 
r1980 + lots of adjustments to fit the new RackCode authorization framework

12 years agor1979 + allow a comment to end RackCode text
Denis Ovsienko [Tue, 17 Jun 2008 11:13:56 +0000 (11:13 +0000)] 
r1979 + allow a comment to end RackCode text
+ validate RackCode before saving it into DB

12 years agor1978 + remove debug output from renderRackObject()
Denis Ovsienko [Mon, 16 Jun 2008 22:38:04 +0000 (22:38 +0000)] 
r1978 + remove debug output from renderRackObject()
+ switch from authorized() to probeLocation()
+ drop renderPermissions() and renderPermissionsEditForm()
+ rework renderAccounts() into renderUserList(): add tag filter
+ renderAccountsEditForm() becomes renderUserListEditor()
+ adjust account operation names to those in navigation list
+ simplify renderRackCodeViewer()
+ rename renderEntityTags() to renderEntityTagChainEditor() and fix its users accordingly
+ introduce renderRackCodeEditor(), renderUser(), renderUserPasswordEditor(), renderUserTags()
+ renderTagRollerForRow(): add missing FORM closure

12 years agor1977 + distinguish saveTags as operation name
Denis Ovsienko [Mon, 16 Jun 2008 22:29:37 +0000 (22:29 +0000)] 
r1977 + distinguish saveTags as operation name
+ rename accounts to userlist
+ introduce "user" page and stuff
+ "perms" page now uses RackCode functions instead of old ones
+ dropped experimental "rackcode" page
+ probeLocation() effectively replaces authorized()

12 years agor1976 + authorize(): consult gotClearanceForTagChain() (RackCode) instead of authoriz...
Denis Ovsienko [Mon, 16 Jun 2008 22:25:58 +0000 (22:25 +0000)] 
r1976 + authorize(): consult gotClearanceForTagChain() (RackCode) instead of authorized() (UserPermission)
+ introduce probeLocation() as a functional replacement for authorized()
+ authenticated(): don't generate a warning for non-existent user
+ invent getUsernameByID()

12 years agor1975 + get rid of the old user permission table
Denis Ovsienko [Mon, 16 Jun 2008 22:22:15 +0000 (22:22 +0000)] 
r1975 + get rid of the old user permission table
+ push in page and tab autotags ourselves

12 years agor1974 + list things done
Denis Ovsienko [Mon, 16 Jun 2008 22:21:10 +0000 (22:21 +0000)] 
r1974 + list things done

12 years agor1973 + pretend being 0.16.0
Denis Ovsienko [Mon, 16 Jun 2008 22:20:46 +0000 (22:20 +0000)] 
r1973 + pretend being 0.16.0

12 years agor1972 + add dynamic_title_user()
Denis Ovsienko [Mon, 16 Jun 2008 22:18:47 +0000 (22:18 +0000)] 
r1972 + add dynamic_title_user()

12 years agor1971 + rename getGlobalAutoTags() to getUserAutoTags(), because it doesn't add locat...
Denis Ovsienko [Mon, 16 Jun 2008 22:18:19 +0000 (22:18 +0000)] 
r1971 + rename getGlobalAutoTags() to getUserAutoTags(), because it doesn't add location autotags any more

12 years agor1970 + getUserAccounts(): treat given tag filter
Denis Ovsienko [Mon, 16 Jun 2008 22:17:35 +0000 (22:17 +0000)] 
r1970 + getUserAccounts(): treat given tag filter
+ drop getUserPermissions(), commitGrantPermission(), commitRevokePermission()
+ make getLongText() do some real work and rename it to loadScript()
+ add loadUserTags(), saveScript(), saveUserPassword()

12 years agor1969 + adjust UserPermission records for 0.15.1 object tabs rename
Denis Ovsienko [Mon, 16 Jun 2008 22:14:28 +0000 (22:14 +0000)] 
r1969 + adjust UserPermission records for 0.15.1 object tabs rename
+ adjust TagStorage and perform UserPermission replacement by RackCode

12 years agor1968 + move Config up
Denis Ovsienko [Mon, 16 Jun 2008 22:11:23 +0000 (22:11 +0000)] 
r1968 + move Config up
+ drop UserPermission
+ introduce Script
+ adjust TagStorage

12 years agor1967 + rename accounts management functions more consistently
Denis Ovsienko [Mon, 16 Jun 2008 22:09:56 +0000 (22:09 +0000)] 
r1967 + rename accounts management functions more consistently
+ account bypass arg name becomes user_id, not id
+ drop revokePermission() and grantPermission()
+ fix message text
+ new handlers: saveUserTags(), changePassword() and saveRackCode()

12 years agor1966 + abortLex1(): output character code
Denis Ovsienko [Mon, 16 Jun 2008 22:04:25 +0000 (22:04 +0000)] 
r1966 + abortLex1(): output character code
+ getLexemsFromRackCode(): tolerate both CR and LF
+ getRackCode(): adjust text retrieving function name

12 years agor1965 + more cleanups in syntax analyzer
Denis Ovsienko [Sat, 14 Jun 2008 20:42:59 +0000 (20:42 +0000)] 
r1965 + more cleanups in syntax analyzer
+ draft code for RackCode evaluation

12 years agor1964 + getGlobalAutoTags(): generate auto-tags for page and tab names
Denis Ovsienko [Sat, 14 Jun 2008 20:41:16 +0000 (20:41 +0000)] 
r1964 + getGlobalAutoTags(): generate auto-tags for page and tab names

12 years agor1963 + optimized code tree
Denis Ovsienko [Fri, 13 Jun 2008 21:02:29 +0000 (21:02 +0000)] 
r1963 + optimized code tree
+ initial evaluation functions draft
+ updated comments

12 years agor1962 + update comments
Denis Ovsienko [Thu, 12 Jun 2008 19:41:39 +0000 (19:41 +0000)] 
r1962 + update comments
+ remove debug call
+ check last char of the ID going out from the lexical scanner

12 years agor1961 + a better implementation of the syntax analyzer
Denis Ovsienko [Thu, 12 Jun 2008 18:32:35 +0000 (18:32 +0000)] 
r1961 + a better implementation of the syntax analyzer

12 years agor1960 + more work done, wrt syntax analysis in particular
Denis Ovsienko [Thu, 12 Jun 2008 15:49:20 +0000 (15:49 +0000)] 
r1960 + more work done, wrt syntax analysis in particular

12 years agor1957 + initial RackCode source: getLexFromCodetext()
Denis Ovsienko [Tue, 10 Jun 2008 15:23:15 +0000 (15:23 +0000)] 
r1957 + initial RackCode source: getLexFromCodetext()

12 years agor1956 + merged some cleanups sent by Jonathan Thurman
Denis Ovsienko [Mon, 9 Jun 2008 21:06:59 +0000 (21:06 +0000)] 
r1956 + merged some cleanups sent by Jonathan Thurman

12 years agor1955 + fix minor warning about undefined variable
Denis Ovsienko [Sat, 7 Jun 2008 13:29:09 +0000 (13:29 +0000)] 
r1955 + fix minor warning about undefined variable

12 years agor1954 + each time we call useSelectBlade(), supply it with the caller name for better...
Denis Ovsienko [Sat, 7 Jun 2008 11:46:19 +0000 (11:46 +0000)] 
r1954 + each time we call useSelectBlade(), supply it with the caller name for better debugging

12 years agor1953 + rename IPv4 addition/removal functions more appropriately and clean them up
Denis Ovsienko [Sat, 7 Jun 2008 11:39:44 +0000 (11:39 +0000)] 
r1953 + rename IPv4 addition/removal functions more appropriately and clean them up
+ ditto for operation names
+ make use of addTagForEntity() instead of calling useInsertBlade() directly

12 years agor1952 + implement tag roller
Denis Ovsienko [Fri, 6 Jun 2008 18:49:09 +0000 (18:49 +0000)] 
r1952 + implement tag roller
+ introduce addTagForEntity() and fix saveEntityTags() to stop calling useInsertBlade() directly

12 years agor1951 + don't forget IPV4_AUTO_RELEASE variable on reset
Denis Ovsienko [Fri, 6 Jun 2008 17:19:37 +0000 (17:19 +0000)] 
r1951 + don't forget IPV4_AUTO_RELEASE variable on reset

12 years agor1950 + get rid of legacy code in getRackRowInfo()
Denis Ovsienko [Fri, 6 Jun 2008 17:17:56 +0000 (17:17 +0000)] 
r1950 + get rid of legacy code in getRackRowInfo()

12 years agor1947 + pre-release fixes
Denis Ovsienko [Thu, 5 Jun 2008 15:14:56 +0000 (15:14 +0000)] 
r1947 + pre-release fixes

12 years agor1946 + last adjstments before 0.15.1 release
Denis Ovsienko [Thu, 5 Jun 2008 15:09:06 +0000 (15:09 +0000)] 
r1946 + last adjstments before 0.15.1 release

12 years agor1945 + fit the next 0.15.1 release better
Denis Ovsienko [Thu, 5 Jun 2008 10:42:21 +0000 (10:42 +0000)] 
r1945 + fit the next 0.15.1 release better

12 years agor1944 + closing ticket:23 (NAT rules on IPv4 address page)
Denis Ovsienko [Thu, 5 Jun 2008 10:38:09 +0000 (10:38 +0000)] 
r1944 + closing ticket:23 (NAT rules on IPv4 address page)
+ minor cleanups

12 years agor1943 + further work on ticket:23
Denis Ovsienko [Wed, 4 Jun 2008 14:51:16 +0000 (14:51 +0000)] 
r1943 + further work on ticket:23

12 years agor1942 + fixed ticket:169, working on ticket:23
Denis Ovsienko [Wed, 4 Jun 2008 14:34:17 +0000 (14:34 +0000)] 
r1942 + fixed ticket:169, working on ticket:23

12 years agor1941 + highlight the IP address on the object, which we have navigated from
Denis Ovsienko [Tue, 3 Jun 2008 22:55:13 +0000 (22:55 +0000)] 
r1941 + highlight the IP address on the object, which we have navigated from

12 years agor1940 + align allocations table according to the current style
Denis Ovsienko [Tue, 3 Jun 2008 15:08:08 +0000 (15:08 +0000)] 
r1940 + align allocations table according to the current style
+ give IPv4 address allocation handlers an overhaul
+ handle reservation release (new UI option)
+ cleanups here and there

12 years agor1939 + introduce IPV4_AUTO_RELEASE option
Denis Ovsienko [Tue, 3 Jun 2008 15:07:24 +0000 (15:07 +0000)] 
r1939 + introduce IPV4_AUTO_RELEASE option

12 years agor1938 + fix warning about missing array reference
Denis Ovsienko [Tue, 3 Jun 2008 12:21:51 +0000 (12:21 +0000)] 
r1938 + fix warning about missing array reference

12 years agor1937 + enable preset tags for object creation
Denis Ovsienko [Tue, 3 Jun 2008 11:34:44 +0000 (11:34 +0000)] 
r1937 + enable preset tags for object creation

12 years agor1936 + fix form element names
Denis Ovsienko [Tue, 3 Jun 2008 10:10:45 +0000 (10:10 +0000)] 
r1936 + fix form element names

12 years agor1935 + eliminate the tab to add a single object, it's useless
Denis Ovsienko [Tue, 3 Jun 2008 09:53:23 +0000 (09:53 +0000)] 
r1935 + eliminate the tab to add a single object, it's useless

12 years agor1934 + treat tag list to pre-assign to newly added rack(s)
Denis Ovsienko [Tue, 3 Jun 2008 08:43:51 +0000 (08:43 +0000)] 
r1934 + treat tag list to pre-assign to newly added rack(s)
+ commitAddRack(): use standard helpers, don't invent wheels

12 years agor1933 + worked on ticket:40 (adding multiple racks)
Denis Ovsienko [Mon, 2 Jun 2008 16:51:03 +0000 (16:51 +0000)] 
r1933 + worked on ticket:40 (adding multiple racks)

12 years agor1932 + fix SNMP harvester
Denis Ovsienko [Thu, 29 May 2008 15:45:10 +0000 (15:45 +0000)] 
r1932 + fix SNMP harvester
+ fix L2 address search

12 years agor1931 + tossing SNMP code around
Denis Ovsienko [Thu, 29 May 2008 12:49:22 +0000 (12:49 +0000)] 
r1931 + tossing SNMP code around
+ 2950G update

12 years agor1930 + merge killsystem's patch (SNMP and OEM S/N)
Denis Ovsienko [Tue, 20 May 2008 13:50:25 +0000 (13:50 +0000)] 
r1930 + merge killsystem's patch (SNMP and OEM S/N)

12 years agor1929 + revert typo introduced by changeset:1772 (pointed by Aaron Dummer)
Denis Ovsienko [Mon, 12 May 2008 18:28:09 +0000 (18:28 +0000)] 
r1929 + revert typo introduced by changeset:1772 (pointed by Aaron Dummer)

12 years agor1927 + add missing release timestamp
Denis Ovsienko [Fri, 9 May 2008 21:02:48 +0000 (21:02 +0000)] 
r1927 + add missing release timestamp

12 years agor1925 + fix missing global declaration RackTables-0.15.0
Denis Ovsienko [Fri, 9 May 2008 20:56:17 +0000 (20:56 +0000)] 
r1925 + fix missing global declaration

12 years agor1924 + better column header for accounts list
Denis Ovsienko [Fri, 9 May 2008 20:22:40 +0000 (20:22 +0000)] 
r1924 + better column header for accounts list

12 years agor1923 + and another image fix
Denis Ovsienko [Fri, 9 May 2008 20:21:05 +0000 (20:21 +0000)] 
r1923 + and another image fix

12 years agor1922 + another fix for NATv4
Denis Ovsienko [Fri, 9 May 2008 20:18:53 +0000 (20:18 +0000)] 
r1922 + another fix for NATv4
+ fix images for account mgmt tab

12 years agor1921 + fix addition of NATv4 rule
Denis Ovsienko [Fri, 9 May 2008 20:11:23 +0000 (20:11 +0000)] 
r1921 + fix addition of NATv4 rule

12 years agor1920 + drop more unused images
Denis Ovsienko [Fri, 9 May 2008 19:22:55 +0000 (19:22 +0000)] 
r1920 + drop more unused images

12 years agor1919 + delete unused image
Denis Ovsienko [Fri, 9 May 2008 19:15:38 +0000 (19:15 +0000)] 
r1919 + delete unused image
+ fix 0.15.0

12 years agor1918 + it's going to be 0.15
Denis Ovsienko [Fri, 9 May 2008 18:31:09 +0000 (18:31 +0000)] 
r1918 + it's going to be 0.15

12 years agor1917 + fix chapter number for Raisecom hardware
Denis Ovsienko [Fri, 9 May 2008 18:28:03 +0000 (18:28 +0000)] 
r1917 + fix chapter number for Raisecom hardware

12 years agor1916 + add tag records into sample data
Denis Ovsienko [Fri, 9 May 2008 17:50:52 +0000 (17:50 +0000)] 
r1916 + add tag records into sample data