racktables
7 days agoupgrade CodeMirror from 5.48.2 to 5.49.0 master
Denis Ovsienko [Tue, 15 Oct 2019 19:15:34 +0000 (20:15 +0100)] 
upgrade CodeMirror from 5.48.2 to 5.49.0

[skip ci]

5 weeks agoclarify the previous commit
Denis Ovsienko [Sun, 15 Sep 2019 14:30:32 +0000 (15:30 +0100)] 
clarify the previous commit

[skip ci]

5 weeks agoAdd snmp syncing support for Arista DCS-7050SX-64 (#264)
Denis Ovsienko [Sun, 15 Sep 2019 14:20:04 +0000 (15:20 +0100)] 
Add snmp syncing support for Arista DCS-7050SX-64 (#264)

In addition, this adds a new processor called 'arista-any-QSFP+' which should be
able to get interfaces named like the following:

Ethernet49/1
Ethernet49/2
Ethernet49/3
Ethernet49/4
Ethernet50/1
...

5 weeks agoTravis CI: fix the build after Ubuntu upgrade
Denis Ovsienko [Sun, 15 Sep 2019 13:08:16 +0000 (14:08 +0100)] 
Travis CI: fix the build after Ubuntu upgrade

Travis CI had changed the default Ubuntu version from 14.04 to 16.04,
which had broken the following jobs:
* PHP 5.5 (because Travis does not supply a PHP 5.5 phpenv archive for
  Ubuntu 16.04)
* PHP 7.0 (because PHPUnit was upgraded from 6.4.3 to 7.5.0)
* PHP 7.1 (because PHPUnit was upgraded from 6.4.3 to 8.0.4)

Complete the change started in commit b3a99c9 and specify the latest
PHPUnit 6 for the PHP 7.0 job and the latest PHPUnit 7 for the PHP 7.1
job. Bump PHP 7.2 and 7.3 jobs to the latest PHPUnit 7 too. Remove PHP
5.5 from the build matrix.

6 weeks agoAdd snmp syncing support for Arista DCS-7050SX-64 264/head
Lance Albertson [Fri, 6 Sep 2019 22:49:54 +0000 (15:49 -0700)] 
Add snmp syncing support for Arista DCS-7050SX-64

In addition, this adds a new processor called 'arista-any-QSFP+' which should be
able to get interfaces named like the following:

Ethernet49/1
Ethernet49/2
Ethernet49/3
Ethernet49/4
Ethernet50/1
...

2 months agouse vertical writing mode in the 802.1Q report
Denis Ovsienko [Wed, 21 Aug 2019 21:43:41 +0000 (22:43 +0100)] 
use vertical writing mode in the 802.1Q report

It used to be inconvenient to view the domain/VLAN matrix on setups with
many VLAN domains. I tried to switch the domain THs to vertical mode
about 7 years ago, but it didn't work well at that time. Nowadays it is
just a matter of a CSS property, it turns out.

* pi.css
* render8021QReport()

[skip ci]

2 months agoupgrade CodeMirror from 5.46.0 to 5.48.2
Denis Ovsienko [Sun, 4 Aug 2019 20:03:54 +0000 (21:03 +0100)] 
upgrade CodeMirror from 5.46.0 to 5.48.2

[skip ci]

4 months agoamend SQL to work on MySQL 8 (Mantis#1909)
Arkadi Colson [Wed, 19 Jun 2019 14:22:12 +0000 (15:22 +0100)] 
amend SQL to work on MySQL 8 (Mantis#1909)

ROW is a MySQL 8 keyword.

4 months agoadd sections for 0.21.4
Denis Ovsienko [Wed, 19 Jun 2019 14:12:30 +0000 (15:12 +0100)] 
add sections for 0.21.4

[skip ci]

4 months agoTravis CI: update custom PHPUnit from 7.5.7 to .12
Denis Ovsienko [Thu, 13 Jun 2019 08:17:57 +0000 (09:17 +0100)] 
Travis CI: update custom PHPUnit from 7.5.7 to .12

Reduce hard-coding and make the .phar download conditional while at it.

4 months ago0.21.3: cut the release RackTables-0.21.3
Denis Ovsienko [Wed, 12 Jun 2019 14:12:37 +0000 (15:12 +0100)] 
0.21.3: cut the release

4 months agodictionary: add recent Fedora versions
Denis Ovsienko [Wed, 12 Jun 2019 11:46:32 +0000 (12:46 +0100)] 
dictionary: add recent Fedora versions

[skip ci]

4 months agofix an XSS issue in an error message
Denis Ovsienko [Tue, 11 Jun 2019 14:42:16 +0000 (15:42 +0100)] 
fix an XSS issue in an error message

The issue was reported by Diego Di Nardo.

5 months agoQuick fix of formatting. 258/head
MichaelTiernan [Tue, 21 May 2019 17:46:54 +0000 (13:46 -0400)] 
Quick fix of formatting.

5 months agofix hook integration in Cacti and Munin pligins
Denis Ovsienko [Fri, 10 May 2019 11:45:29 +0000 (12:45 +0100)] 
fix hook integration in Cacti and Munin pligins

Commit 011df35 introduced this issue. With "module=image" and either of
the plugins enabled RackTables failed to fail when "img" was set to an
invalid value. This was because the plugins' extension functions always
return TRUE to dispatchImageRequest(), which concluded the work was
always done and thus never raised the default exception. Make the return
in the plugins conditional to fix that.

5 months agoauthorize8021QChangeRequests(): amend PHP array syntax
Denis Ovsienko [Sat, 4 May 2019 21:04:09 +0000 (22:04 +0100)] 
authorize8021QChangeRequests(): amend PHP array syntax

See Mantis#1905. Although support for PHP 5.3 is not a goal, the rest of
PHP code uses traditional array syntax, so let's make it consistent.

5 months agoadd a log entry limit to the object page (Mantis#769)
Denis Ovsienko [Fri, 26 Apr 2019 03:54:00 +0000 (04:54 +0100)] 
add a log entry limit to the object page (Mantis#769)

* getConfigDefaults(): add OBJECTLOG_PREVIEW_ENTRIES
* install.php: idem
* upgrade.php: idem
* renderObject(): use the option to limit the amount of entries

5 months agoupgrade CodeMirror from 5.45.0 to 5.46.0
Denis Ovsienko [Wed, 24 Apr 2019 07:58:45 +0000 (08:58 +0100)] 
upgrade CodeMirror from 5.45.0 to 5.46.0

[skip ci]

6 months agoadd sections for 0.21.3
Denis Ovsienko [Sat, 30 Mar 2019 15:27:17 +0000 (15:27 +0000)] 
add sections for 0.21.3

6 months agodictionary: update OpenWrt entries
Denis Ovsienko [Sat, 30 Mar 2019 15:07:59 +0000 (15:07 +0000)] 
dictionary: update OpenWrt entries

6 months agoupdateObjectAllocation(): fix two PHP messages
Denis Ovsienko [Mon, 1 Apr 2019 08:48:47 +0000 (09:48 +0100)] 
updateObjectAllocation(): fix two PHP messages

Saving an empty working copy would result in the following:

PHP Notice:  Undefined index: rackmulti in ophandlers.php on line 1225
PHP Warning:  Invalid argument supplied for foreach() in ophandlers.php
on line 1225

[skip ci]

6 months ago0.21.2: cut the release RackTables-0.21.2
Denis Ovsienko [Mon, 25 Mar 2019 14:53:51 +0000 (14:53 +0000)] 
0.21.2: cut the release

6 months agoupdate COPYING for 2019
Denis Ovsienko [Mon, 25 Mar 2019 14:26:58 +0000 (14:26 +0000)] 
update COPYING for 2019

[skip ci]

7 months agouse PHPUnit 7.5.7 instead of 8
Denis Ovsienko [Thu, 21 Mar 2019 21:58:08 +0000 (21:58 +0000)] 
use PHPUnit 7.5.7 instead of 8

Run all tests on all PHP versions again.

7 months agoenable minimal CI testing of PHP 7.3
Denis Ovsienko [Thu, 21 Mar 2019 00:10:43 +0000 (00:10 +0000)] 
enable minimal CI testing of PHP 7.3

7 months agofix warnings specific to PHP 7.3
Denis Ovsienko [Thu, 21 Mar 2019 00:09:00 +0000 (00:09 +0000)] 
fix warnings specific to PHP 7.3

PHP Warning:  "continue" targeting switch is equivalent to "break". Did
you mean to use "continue 2"?

* jun10ReadInterfaceStatus()
* addMultiPorts()
* addRealServers()

7 months agoupgrade CodeMirror from 5.43.0 to 5.45.0
Denis Ovsienko [Wed, 20 Mar 2019 23:30:51 +0000 (23:30 +0000)] 
upgrade CodeMirror from 5.43.0 to 5.45.0

[skip ci]

7 months agoadd missing quotes to shell scripts
Denis Ovsienko [Thu, 7 Mar 2019 12:28:01 +0000 (12:28 +0000)] 
add missing quotes to shell scripts

Issue spotted by Mark Brugnoli-Vinten.

8 months agospell product numbers for older HP switch models
Denis Ovsienko [Wed, 20 Feb 2019 00:18:33 +0000 (00:18 +0000)] 
spell product numbers for older HP switch models

[skip ci]

8 months agofixup the previous commit
Denis Ovsienko [Wed, 20 Feb 2019 00:18:07 +0000 (00:18 +0000)] 
fixup the previous commit

[skip ci]

8 months agoadd SNMP support for HP Switches (GH #252)
Sergey Rychka [Wed, 20 Feb 2019 00:01:52 +0000 (03:01 +0300)] 
add SNMP support for HP Switches (GH #252)

add SNMP support for Hp Procurve 5406zl  (Mantis#1485)
add SNMP support for HP A5120-24G (Mantis#1257)
add SNMP support for HP V1910-48G Switch JE009A (Mantis#1193)
add SNMP support for HP Procurve 2900 (Mantis#689)

8 months agogit-commit: remove unnecessary backticks
Denis Ovsienko [Mon, 18 Feb 2019 21:38:58 +0000 (21:38 +0000)] 
git-commit: remove unnecessary backticks

[skip ci]

8 months agogit-commit: make a few variables readonly
Denis Ovsienko [Mon, 18 Feb 2019 21:35:56 +0000 (21:35 +0000)] 
git-commit: make a few variables readonly

[skip ci]

8 months agotests: disregard PHPUnit 8 for now
Denis Ovsienko [Mon, 18 Feb 2019 16:12:20 +0000 (16:12 +0000)] 
tests: disregard PHPUnit 8 for now

In Travis CI PHP 7.2 now comes with PHPUnit 8, which seems to require
rewriting the tests in a way that is not compatible with older PHPUnit
versions. Introduce SKIP_PHPUNIT into the Travis CI matrix to avoid
running PHPUnit 8 on PHP 7.2 until RackTables code is ready (and
potentially to prevent running older PHPUnit versions on older PHP
versions if the switch happens).

8 months agofixup the previous commits
Denis Ovsienko [Thu, 31 Jan 2019 23:50:30 +0000 (23:50 +0000)] 
fixup the previous commits

8 months agoUpdate snmp.php 251/head
Sergey Rychka [Thu, 31 Jan 2019 13:20:17 +0000 (16:20 +0300)] 
Update snmp.php

add SNMP support for Cisco Catalyst 3850-48T (Mantis#1169 and Mantis#1423)
add SNMP support for Cisco 871 (Mantis#1355)
add SNMP support for Cisco Catalyst Model WS-C3850-24T (Mantis#1701)
add SNMP support for Cisco Nexus 3064T (Mantis#1697)

8 months agoUpdate dictionary.php
Sergey Rychka [Thu, 31 Jan 2019 13:11:03 +0000 (16:11 +0300)] 
Update dictionary.php

add SNMP support for Cisco Catalyst 3850-48T (Mantis#1169 and Mantis#1423)
add SNMP support for Cisco 871 (Mantis#1355)
add SNMP support for Cisco Catalyst Model WS-C3850-24T (Mantis#1701)
add SNMP support for Cisco Nexus 3064T (Mantis#1697)

8 months agofunction ios15ShortenIfName_real added to handle port-channel interfaces names correc... 247/head
Vasilii Shashkov [Wed, 23 Jan 2019 06:04:08 +0000 (13:04 +0700)] 
function ios15ShortenIfName_real added to handle port-channel interfaces names correctly - ios15 does not support shorten "po" interface name in cli view

8 months agoupgrade CodeMirror from 5.42.2 to 5.43.0
Denis Ovsienko [Tue, 22 Jan 2019 22:18:07 +0000 (22:18 +0000)] 
upgrade CodeMirror from 5.42.2 to 5.43.0

[skip ci]

8 months agoremove more trailing spaces
Denis Ovsienko [Tue, 22 Jan 2019 22:14:43 +0000 (22:14 +0000)] 
remove more trailing spaces

* renderRackspace()
* snmp.php
* GetChildrenListTest.php
* LinkTriggerTest::setUpBeforeClass()
* StringInsertHrefsTest::setUpBeforeClass()

[skip ci]

8 months agoios15ReadLLDPStatus(): add a break for consistency
Denis Ovsienko [Tue, 22 Jan 2019 22:04:31 +0000 (22:04 +0000)] 
ios15ReadLLDPStatus(): add a break for consistency

[skip ci]

8 months agofixup more code style
Denis Ovsienko [Tue, 22 Jan 2019 22:01:31 +0000 (22:01 +0000)] 
fixup more code style

Put spacing right and do not use empty() to test for an empty string.

* hpprocurveN1178ReadLLDPStatus()
* hpprocurveN1178ReadInterfaceStatus()
* hpprocurveN1178ReadMacList()
* hpprocurveN1178Read8021QConfig()
* hpprocurveN1178TranslatePushQueue()

[skip ci]

8 months agofixup some code style
Denis Ovsienko [Tue, 22 Jan 2019 21:32:21 +0000 (21:32 +0000)] 
fixup some code style

Remove excess braces, put indentation right and simplify a few if's.

* hpprocurveN1178ReadLLDPStatus()
* hpprocurveN1178ReadInterfaceStatus()
* hpprocurveN1178ReadMacList()
* hpprocurveN1178Read8021QConfig()
* hpprocurveN1178TranslatePushQueue()

[skip ci]

9 months agogit-commit: say add/update in the default message
Denis Ovsienko [Tue, 22 Jan 2019 15:18:33 +0000 (15:18 +0000)] 
git-commit: say add/update in the default message

The script used to log "update <filename>" regardless if it was a new
file or a change to an existing file. To make it easier to follow the
history, have it log "add <filename>" in the former case. Replace a
long if() wrapper with an early return while at it.

[skip ci]

9 months agoUpdate regexp in func hpprocurveN1178Read8021QConfig to match Trk interfaces on HP...
igloo777 [Mon, 21 Jan 2019 14:24:12 +0000 (21:24 +0700)] 
Update regexp in func hpprocurveN1178Read8021QConfig to match Trk interfaces on HP Procurve (#245)

9 months agofixup the previous commit
Denis Ovsienko [Sun, 20 Jan 2019 00:49:31 +0000 (00:49 +0000)] 
fixup the previous commit

[skip ci]

9 months agoadd SNMP support for HP switches (GH #243)
Sergey Rychka [Sun, 20 Jan 2019 00:36:59 +0000 (03:36 +0300)] 
add SNMP support for HP switches (GH #243)

add SNMP support for HP 1810-24G (J9450A) (Mantis#1379)
add SNMP support for HP 1810-8G (J9449A) (Mantis#1377)
add SNMP support for HP 1810-24G v2 (J9803A) (Mantis#1285)

9 months agogit-commit: clarify the usage for -a and -d
Denis Ovsienko [Sat, 19 Jan 2019 19:05:11 +0000 (19:05 +0000)] 
git-commit: clarify the usage for -a and -d

[skip ci]

9 months agofixed typo for breed io15 in function queryTerminal
Vasilii Shashkov [Tue, 15 Jan 2019 07:50:30 +0000 (14:50 +0700)] 
fixed typo for breed io15 in function queryTerminal

9 months agotests: fixup the previous commit
Denis Ovsienko [Mon, 14 Jan 2019 22:29:21 +0000 (22:29 +0000)] 
tests: fixup the previous commit

9 months agotests: make the express test sequence safer
Denis Ovsienko [Mon, 14 Jan 2019 18:02:03 +0000 (18:02 +0000)] 
tests: make the express test sequence safer

9 months agogit-commit: try to clean up on a commit failure
Denis Ovsienko [Sun, 13 Jan 2019 22:02:58 +0000 (22:02 +0000)] 
git-commit: try to clean up on a commit failure

[skip ci]

9 months agogit-commit: factor print_error() out
Denis Ovsienko [Sun, 13 Jan 2019 20:46:49 +0000 (20:46 +0000)] 
git-commit: factor print_error() out

[skip ci]

9 months agogit-commit: add a check for FILEPATH
Denis Ovsienko [Sun, 13 Jan 2019 20:32:02 +0000 (20:32 +0000)] 
git-commit: add a check for FILEPATH

Test that the file is not outside of the repository directory. While at
it, move the non-empty check into git_commit_or_exit() as it actually
belongs there.

[skip ci]

9 months agogit-commit: add support for -M (replace|append)
Denis Ovsienko [Sun, 13 Jan 2019 19:25:01 +0000 (19:25 +0000)] 
git-commit: add support for -M (replace|append)

[skip ci]

9 months agogit-commit: fixup the help text for -u
Denis Ovsienko [Sun, 13 Jan 2019 00:33:56 +0000 (00:33 +0000)] 
git-commit: fixup the help text for -u

[skip ci]

9 months agogit-commit: print the usage text on -h only
Denis Ovsienko [Thu, 10 Jan 2019 23:27:01 +0000 (23:27 +0000)] 
git-commit: print the usage text on -h only

On an option error instead of printing the full text only suggest the -h
option as that is more appropriate for stderr.

[skip ci]

9 months agogit-commit: fixup issues from previous commits
Denis Ovsienko [Thu, 10 Jan 2019 23:03:03 +0000 (23:03 +0000)] 
git-commit: fixup issues from previous commits

[skip ci]

9 months agoupgrade CodeMirror from 5.41.0 to 5.42.2
Denis Ovsienko [Thu, 10 Jan 2019 22:17:23 +0000 (22:17 +0000)] 
upgrade CodeMirror from 5.41.0 to 5.42.2

[skip ci]

9 months agogit-commit: add an early check for -o
Denis Ovsienko [Tue, 8 Jan 2019 22:54:26 +0000 (22:54 +0000)] 
git-commit: add an early check for -o

9 months agospell the product number for HP 1810G-24
Denis Ovsienko [Tue, 8 Jan 2019 22:08:59 +0000 (22:08 +0000)] 
spell the product number for HP 1810G-24

[skip ci]

9 months agogit-commit: add -v for git verbosity level
Denis Ovsienko [Tue, 8 Jan 2019 22:05:50 +0000 (22:05 +0000)] 
git-commit: add -v for git verbosity level

Make it possible for the calling PHP code to receive the git command(s)
output on request. Make the current quiet mode the default to preserve
some backward compatibility.

9 months agogit-commit: add an error check for mkdir
Denis Ovsienko [Tue, 8 Jan 2019 21:40:27 +0000 (21:40 +0000)] 
git-commit: add an error check for mkdir

[skip ci]

9 months agosnmp: add support for a variant of HP JE006A (Mantis #1293)
Christoph Goth [Thu, 14 Aug 2014 20:30:00 +0000 (21:30 +0100)] 
snmp: add support for a variant of HP JE006A (Mantis #1293)

HP JE006A is a 3Com 3CRBSG2893.

[skip ci]

9 months agogit-commit: add -h for "help"
Denis Ovsienko [Sat, 5 Jan 2019 23:05:04 +0000 (23:05 +0000)] 
git-commit: add -h for "help"

[skip ci]

9 months agogit-commit: add more error checks
Denis Ovsienko [Sat, 5 Jan 2019 22:58:01 +0000 (22:58 +0000)] 
git-commit: add more error checks

Test that the provided <repodir> is good before making any changes. Test
that git is available. Test that "git add" and "git commit" worked.

Move the default value for COMMITMSG right into the git command. Update
the usage text.

[skip ci]

9 months agospell the product number for HP 1910-24G
Denis Ovsienko [Sat, 5 Jan 2019 21:53:42 +0000 (21:53 +0000)] 
spell the product number for HP 1910-24G

Clarify the end result of the following series of commits (in
chronological order):

e7705e2a add HP ProCurve 1910-24G
8df12894 finalize the previous commit
8db81368 dict: remove duplicate item HP ProCurve 1910-24G
e6562cdb SNMP: fix dict_key for HP 1910-24G

[skip ci]

9 months agogit-commit: implement -d for git commit --date
Denis Ovsienko [Thu, 3 Jan 2019 18:09:23 +0000 (18:09 +0000)] 
git-commit: implement -d for git commit --date

[skip-ci]

9 months agogit-commit: make the actions more fine-grained
Denis Ovsienko [Thu, 3 Jan 2019 17:46:49 +0000 (17:46 +0000)] 
git-commit: make the actions more fine-grained

Introduce an optional -o ("only") option to request only a specific
step of the pull-commit-push workflow. This is useful for updating many
files in a batch -- any changes will still end up one commit per file,
but the workflow will be pull-commit-commit-...-commit-commit-push, which
will not multiply the delay accessing a slow git remote before and after
every attempted file.

Without the option the script will work same as before this change.

[skip ci]

9 months agogit-commit: move the code into smaller functions
Denis Ovsienko [Thu, 3 Jan 2019 13:14:24 +0000 (13:14 +0000)] 
git-commit: move the code into smaller functions

[skip ci]

9 months agofixup the previous commit
Denis Ovsienko [Thu, 3 Jan 2019 00:21:33 +0000 (00:21 +0000)] 
fixup the previous commit

Put HP JG311A ports right and fix some regexp issues.

[skip ci]

9 months agoUpdate snmp.php
rychka [Tue, 18 Dec 2018 14:02:43 +0000 (17:02 +0300)] 
Update snmp.php

add SNMP support for HP 1950 48G 2SFP+ 2XGT Switch (Mantis#1599)
add SNMP support for HPE FlexFabric 5900AF 48XG 4QSFP+ Switch (Mantis#1841)
add SNMP support for HPE 5500-24G-4SFP Switch (Mantis#1839)
add SNMP support for HP A5800AF-48G Switch with 2 Processors (JG225A) (Mantis#1843)
add SNMP support for HP 1810-8G v2 (J9802A) Switch (Mantis#1287)

9 months agoUpdate dictionary.php
rychka [Tue, 18 Dec 2018 13:53:16 +0000 (16:53 +0300)] 
Update dictionary.php

add SNMP support for HP 1950 48G 2SFP+ 2XGT Switch (Mantis#1599)
add SNMP support for HPE FlexFabric 5900AF 48XG 4QSFP+ Switch (Mantis#1841)
add SNMP support for HPE 5500-24G-4SFP Switch (Mantis#1839)
add SNMP support for HP A5800AF-48G Switch with 2 Processors (JG225A) (Mantis#1843)
add SNMP support for HP 1810-8G v2 (J9802A) Switch (Mantis#1287)

9 months agocallScript(): fixup an error message
Denis Ovsienko [Tue, 1 Jan 2019 16:58:59 +0000 (16:58 +0000)] 
callScript(): fixup an error message

[skip ci]

9 months agogit-commit: quote $SUDOUSER too
Denis Ovsienko [Tue, 1 Jan 2019 16:55:01 +0000 (16:55 +0000)] 
git-commit: quote $SUDOUSER too

9 months agogit-commit: support custom author for the commit
Denis Ovsienko [Tue, 1 Jan 2019 16:53:17 +0000 (16:53 +0000)] 
git-commit: support custom author for the commit

9 months agogit-commit: switch to getopts
Denis Ovsienko [Tue, 1 Jan 2019 16:39:27 +0000 (16:39 +0000)] 
git-commit: switch to getopts

This breaks backward compatibility, but makes it easier to add new
options in future.

9 months agogit-commit: prepend all messages with own filename
Denis Ovsienko [Tue, 1 Jan 2019 12:45:09 +0000 (12:45 +0000)] 
git-commit: prepend all messages with own filename

10 months agogateways/git-commit: handle new files better
Denis Ovsienko [Wed, 19 Dec 2018 13:01:36 +0000 (13:01 +0000)] 
gateways/git-commit: handle new files better

The script works as expected updating existing files, but to add new
files to the repository things need to be done slightly differently.

[skip ci]

10 months agodisplay file comment in the SELECT (Mantis#1419)
Denis Ovsienko [Mon, 17 Dec 2018 17:51:30 +0000 (17:51 +0000)] 
display file comment in the SELECT (Mantis#1419)

* getAllUnlinkedFiles(): include the beginning of the comment into the
  result and return the result as it is
* renderFilesForEntity(): add a round to build the printSelect() input

10 months agosimplify getFilesOfEntity()
Denis Ovsienko [Mon, 17 Dec 2018 17:39:55 +0000 (17:39 +0000)] 
simplify getFilesOfEntity()

10 months agosqueeze some blank lines
Denis Ovsienko [Mon, 17 Dec 2018 16:55:05 +0000 (16:55 +0000)] 
squeeze some blank lines

[skip ci]

10 months agosyncdomain.php: just use basename()
Denis Ovsienko [Thu, 13 Dec 2018 13:14:14 +0000 (13:14 +0000)] 
syncdomain.php: just use basename()

10 months agofixup indentation in snmp.php
Denis Ovsienko [Tue, 11 Dec 2018 17:01:54 +0000 (17:01 +0000)] 
fixup indentation in snmp.php

[skip ci]

10 months agorefine platform tests further
Denis Ovsienko [Wed, 5 Dec 2018 23:30:04 +0000 (23:30 +0000)] 
refine platform tests further

In platform_is_ok() convert the PHP extension tests to declarations and
describe the impact of a failed test iff the test is not critical for the
core RackTables features to work in the default configuration. Ibid,
display the impact of an optional test in the output table when it fails
(this did not work before because platform_function_test() ignored one of
its parameters). Ibid, for the test just use extension_loaded(). Remove
platform_function_test(), which now has no purpose.

[skip ci]

10 months agoplatform_is_ok(): add a non-critical test for cURL
Denis Ovsienko [Wed, 5 Dec 2018 16:19:33 +0000 (16:19 +0000)] 
platform_is_ok(): add a non-critical test for cURL

[skip ci]

10 months agosimplify renderObjectHistory()
Denis Ovsienko [Tue, 4 Dec 2018 12:21:33 +0000 (12:21 +0000)] 
simplify renderObjectHistory()

Just use renderTableViewer(), this among other things yields a better
formatted table.

[skip ci]

10 months agoadd basic integrity checks for config variables
Denis Ovsienko [Fri, 30 Nov 2018 23:43:25 +0000 (23:43 +0000)] 
add basic integrity checks for config variables

Use the configuration defaults data in two new checks in
renderDataIntegrityReport(). One of the checks immediately fails because
the data in getConfigDefaults() did not include ENABLE_BULKPORT_FORM, so
fix that right away.

10 months agomake the configuration defaults data shareable
Denis Ovsienko [Fri, 30 Nov 2018 22:42:21 +0000 (22:42 +0000)] 
make the configuration defaults data shareable

Move the array from resetUIConfig() to a new function,
getConfigDefaults(). Place the new function in dictionary.php as that is
the best way to make it available in the installer (which still does not
use it though). Update renderUIResetForm() to use a new opcode that
works better with the hardcoded require_once in index.php.

10 months agotests: update RenderReportsTest
Denis Ovsienko [Fri, 30 Nov 2018 21:01:09 +0000 (21:01 +0000)] 
tests: update RenderReportsTest

Assert that the integrity report prints the "all clear" message.

Remove some dead code: the class props are no longer required since
commit 4829189; the test condition is always true because
renderLocalReports() does not exist since commit df8739f.

10 months agorenderTableViewer(): quote the TD class value
Denis Ovsienko [Fri, 30 Nov 2018 20:29:31 +0000 (20:29 +0000)] 
renderTableViewer(): quote the TD class value

This way specifying more than one class in the calling function isn't
more difficult than it should be.

[skip ci]

10 months agomake RE_L2_SOLID uppercase-only
Denis Ovsienko [Fri, 30 Nov 2018 19:06:52 +0000 (19:06 +0000)] 
make RE_L2_SOLID uppercase-only

This is a fixup to commit 97792a8.

10 months agoUpdate dictionary.php
rychka [Fri, 30 Nov 2018 10:54:13 +0000 (13:54 +0300)] 
Update dictionary.php

add SNMP support for HP Aruba 2530 48 PoE+ Switch and HP Aruba 2530 24 PoE+ Switch (Mantis#1641)

10 months agoUpdate snmp.php
rychka [Fri, 30 Nov 2018 10:52:32 +0000 (13:52 +0300)] 
Update snmp.php

add SNMP support for HP Aruba 2530 48 PoE+ Switch and HP Aruba 2530 24 PoE+ Switch (Mantis#1641)

10 months agorenderObject(): align some TDs in the NATv4 tables
Denis Ovsienko [Wed, 28 Nov 2018 18:15:58 +0000 (18:15 +0000)] 
renderObject(): align some TDs in the NATv4 tables

[skip ci]

10 months agoeliminate a global variable
Denis Ovsienko [Wed, 28 Nov 2018 13:07:02 +0000 (13:07 +0000)] 
eliminate a global variable

Rewrite addPageHeader() so it does not need the helper array.

10 months agorename getObjectClass() to getCellClass()
Denis Ovsienko [Wed, 28 Nov 2018 12:43:58 +0000 (12:43 +0000)] 
rename getObjectClass() to getCellClass()

This completes the change started in the previous commit -- the function
input may come from realms other than 'object'. Update the functions
below.

* printObjectDetailsForRenderRack()
* renderRack()
* renderDepot()
* renderIPSpaceRecords()
* renderAtomGrid()
* renderCell()
* renderRouterCell()
* renderSLBEntityCell()

10 months agofix colour handling in user account search results
Denis Ovsienko [Wed, 28 Nov 2018 12:22:07 +0000 (12:22 +0000)] 
fix colour handling in user account search results

setEntityColors() caused the following log messages when the search
results included any local user accounts:

PHP Notice:  Undefined index: etags in .../inc/interface-lib.php on
line 1344
PHP Warning:  Invalid argument supplied for foreach() in
.../inc/interface-lib.php on line 1344

This was caused by getAccountSearchResult() constructing and returning
a mock user cell structure, which through the search results eventually
ended up in renderCell(). The latter used to have a workaround for that
specific case (see commit 573214e), but only after the call to
setEntityColors(), which needs the 'etags' data, even when it is an
empty list.

Remove the workaround from renderCell() and remove the unnecessary
custom code from getAccountSearchResult(), which now just calls
spotEntity() like other similar search functions. That delivers 'etags'
to renderCell(), which now has input for getObjectClass(), which now
yields another log message:

PHP Notice:  Undefined index: id in .../interface-lib.php on line 1302

To fix that update getObjectClass() to use the proper index for user
cells like mkCellA() does.

[skip ci]

10 months agoreplace includeJQueryUI() with 2 nullary functions
Denis Ovsienko [Mon, 26 Nov 2018 19:16:23 +0000 (19:16 +0000)] 
replace includeJQueryUI() with 2 nullary functions

The only argument to this function was always a constant.

* includeJQueryUI(): mark deprecated
* includeJQueryUIJS(): a new function
* includeJQueryUICSS(): a new function
* enableTagsPicker(): update to use the new functions
* renderRackSortForm(): idem
* renderGridForm: idem
* renderIPForObject: idem
* renderRackSpaceForObject: idem
* renderIPAddressAllocations: idem
* renderPopupPortSelector: idem

[skip ci]

10 months agospell PHP FALSE in upppercase
Denis Ovsienko [Mon, 26 Nov 2018 18:52:03 +0000 (18:52 +0000)] 
spell PHP FALSE in upppercase

[skip ci]