racktables
3 weeks agoSNMP: add two more Netgear switches (Mantis#1983) master
Denis Ovsienko [Mon, 31 Aug 2020 19:14:33 +0000 (20:14 +0100)] 
SNMP: add two more Netgear switches (Mantis#1983)

[skip ci]

3 weeks agosnmp.php: fix some indentation issues
Denis Ovsienko [Mon, 31 Aug 2020 16:56:12 +0000 (17:56 +0100)] 
snmp.php: fix some indentation issues

3 weeks agodoSwitchSNMPmining(): fixup some pattern matching
Denis Ovsienko [Mon, 31 Aug 2020 16:55:40 +0000 (17:55 +0100)] 
doSwitchSNMPmining(): fixup some pattern matching

Spell end-of-string where it is implied, lose a preg_match() that is
no-op after commit 59736b5.

4 weeks agoSNMP: update some Netgear code
Denis Ovsienko [Sat, 29 Aug 2020 21:11:20 +0000 (22:11 +0100)] 
SNMP: update some Netgear code

Reorder the switch declarations and detect the software version.

[skip ci]

4 weeks agodictionary: add a few more Netgear switches
Denis Ovsienko [Sat, 29 Aug 2020 20:16:01 +0000 (21:16 +0100)] 
dictionary: add a few more Netgear switches

[skip ci]

4 weeks agotests: address most shellcheck warnings in *.sh
Denis Ovsienko [Thu, 27 Aug 2020 23:26:27 +0000 (00:26 +0100)] 
tests: address most shellcheck warnings in *.sh

Use modern style command substitution, add some double quotes, assert
that "cd" is successful, lose an unused variable, reword an underdefined
logical AND, replace "expr" with arithmetic expansion.

4 weeks agotests: factor a function out in express_pre.sh
Denis Ovsienko [Thu, 27 Aug 2020 23:13:32 +0000 (00:13 +0100)] 
tests: factor a function out in express_pre.sh

Addresses a few format warnings from shellcheck and deduplicate the code.
While at it, get the variable right in testPHPExitCodeAndOutput() because
after commit a62537c it worked only by coincidence.

4 weeks agogit-commit: address some shellcheck warnings
Denis Ovsienko [Tue, 25 Aug 2020 22:37:40 +0000 (23:37 +0100)] 
git-commit: address some shellcheck warnings

Use modern style command substitution and more double quotes.

[skip ci]

6 weeks agorenderAttributes(): also display attribute ID
Denis Ovsienko [Wed, 12 Aug 2020 23:12:07 +0000 (00:12 +0100)] 
renderAttributes(): also display attribute ID

As suggested by Lucas Aimaretto on the racktables-users mailing list.

6 weeks agorenderAttributes(): switch to renderTableViewer()
Denis Ovsienko [Wed, 12 Aug 2020 23:08:23 +0000 (00:08 +0100)] 
renderAttributes(): switch to renderTableViewer()

2 months agoadd RHEL 7 to README.md (GH#266)
desmando [Thu, 16 Jul 2020 09:05:38 +0000 (02:05 -0700)] 
add RHEL 7 to README.md (GH#266)

Verified on RHEL 7.8.

4 months agofixup the RackTables web-site URL
Denis Ovsienko [Wed, 27 May 2020 20:38:45 +0000 (21:38 +0100)] 
fixup the RackTables web-site URL

Use HTTPS and a trailing slash to avoid unnecessary redirects.

[skip ci]

4 months agoupgrade CodeMirror from 5.53.2 to 5.54.0
Denis Ovsienko [Sun, 24 May 2020 23:12:50 +0000 (00:12 +0100)] 
upgrade CodeMirror from 5.53.2 to 5.54.0

4 months agoAdd SNMP support for HPE 5130 (JG937A) and A5120 (JG237A) 263/head
lenorcy [Fri, 23 Aug 2019 14:34:45 +0000 (16:34 +0200)] 
Add SNMP support for HPE 5130 (JG937A) and A5120 (JG237A)

4 months agodictionary: add recent Fedora and Ubuntu releases
Denis Ovsienko [Thu, 21 May 2020 09:34:23 +0000 (10:34 +0100)] 
dictionary: add recent Fedora and Ubuntu releases

[skip ci]

4 months agoupdate some installation notes
Denis Ovsienko [Mon, 11 May 2020 13:11:25 +0000 (14:11 +0100)] 
update some installation notes

Remove a couple Linux distributions that are more than 5 years old, add
entries for Fedora 32 and Ubuntu 20.04 based on MariaDB, spell MariaDB as
an alternative consistently.

[skip ci]

4 months agomake release notes consistent after commit ccb8905
Denis Ovsienko [Mon, 11 May 2020 10:59:18 +0000 (11:59 +0100)] 
make release notes consistent after commit ccb8905

[skip ci]

4 months agoadd PHPUnit results cache to .gitignore
Denis Ovsienko [Mon, 11 May 2020 07:24:34 +0000 (08:24 +0100)] 
add PHPUnit results cache to .gitignore

The results cache was introduced in PHPUnit 7.3 and became on by default
in PHPUnit 8. The feature makes no difference in a [single-use] Travis CI
environment, but can enable defects-first test order in a developer
working copy, in case anybody needs it. Hence let's keep it enabled and
ignore the cache file.

[skip ci]

4 months agoupgrade CodeMirror from 5.49.2 to 5.53.2
Denis Ovsienko [Thu, 30 Apr 2020 21:01:28 +0000 (22:01 +0100)] 
upgrade CodeMirror from 5.49.2 to 5.53.2

[skip ci]

4 months agoTravis CI: use the latest PHPUnit 7 for PHP 7.1
Denis Ovsienko [Thu, 30 Apr 2020 20:51:16 +0000 (21:51 +0100)] 
Travis CI: use the latest PHPUnit 7 for PHP 7.1

8 months agoupdate COPYING for 2020
Denis Ovsienko [Sat, 4 Jan 2020 11:38:30 +0000 (11:38 +0000)] 
update COPYING for 2020

[skip ci]

9 months agoTravis CI: add a job for PHP 7.4
Denis Ovsienko [Thu, 19 Dec 2019 20:24:27 +0000 (20:24 +0000)] 
Travis CI: add a job for PHP 7.4

10 months agotests: do not assume PHP CLI is always installed
Denis Ovsienko [Tue, 26 Nov 2019 20:53:00 +0000 (20:53 +0000)] 
tests: do not assume PHP CLI is always installed

10 months agoswitch some documentation URLs to HTTPS
Denis Ovsienko [Mon, 25 Nov 2019 23:02:02 +0000 (23:02 +0000)] 
switch some documentation URLs to HTTPS

[skip ci]

10 months agoallow PHP 7.0 as an untested version
Denis Ovsienko [Sun, 24 Nov 2019 23:54:28 +0000 (23:54 +0000)] 
allow PHP 7.0 as an untested version

As discussed on the mailing list, Ubuntu 16.04 is still around. Let's
consider this again after Ubuntu 20.04 and PHP 7.4 are out.

[skip ci]

10 months agoTravis CI: use default PHPUnit (8) for PHP 7.[23]
Denis Ovsienko [Tue, 19 Nov 2019 23:05:53 +0000 (23:05 +0000)] 
Travis CI: use default PHPUnit (8) for PHP 7.[23]

Also explain it better why PHP 7.0 is not in the matrix and PHP 7.1 uses
a custom PHPUnit version.

10 months agotests: list PHPUnit 8 as a known version
Denis Ovsienko [Tue, 19 Nov 2019 22:59:02 +0000 (22:59 +0000)] 
tests: list PHPUnit 8 as a known version

Leave versions 6 and 7 in place as they run the current tests fine.

10 months agotests: rewrite a test without assertArraySubset()
Denis Ovsienko [Tue, 19 Nov 2019 22:50:55 +0000 (22:50 +0000)] 
tests: rewrite a test without assertArraySubset()

"assertArraySubset() is deprecated and will be removed in PHPUnit 9."

The replacement works with PHPUnit 6, 7 and 8.

10 months agotests: use an assertion, not @expectedException
Denis Ovsienko [Tue, 19 Nov 2019 22:36:33 +0000 (22:36 +0000)] 
tests: use an assertion, not @expectedException

The annotation is deprecated in PHPUnit 8 and causes lots of warnings.
The method (which is the recommended replacement) works since at least
PHPUnit 6.

10 months agotests: declare setup/teardown methods void
Denis Ovsienko [Tue, 19 Nov 2019 21:59:35 +0000 (21:59 +0000)] 
tests: declare setup/teardown methods void

Prepare for one of the backward incompatible changes of PHPUnit 8:

PHP Fatal error:  Declaration of ...::setUpBeforeClass() must be
compatible with PHPUnit\Framework\TestCase::setUpBeforeClass(): void

However, with this change the tests still pass with PHPUnit 6 and 7.

10 months agotests: refine PHPUnit presence checks
Denis Ovsienko [Tue, 19 Nov 2019 00:11:11 +0000 (00:11 +0000)] 
tests: refine PHPUnit presence checks

Make express_phpunit.sh distinguish between unavailable PHPUnit (not
installed at all or PHPUNIT_BIN pointed to a file that lacks the
executable permission) and PHPUnit that is available, but has an
unsupported version. Direct the error messages to stderr while at it.

[skip ci]

10 months agodrop support for PHP 5.x and 7.0
Denis Ovsienko [Sun, 17 Nov 2019 22:25:44 +0000 (22:25 +0000)] 
drop support for PHP 5.x and 7.0

As proposed on the mailing list on 4th of July 2019.

10 months agoadd the usual sections for the next release
Denis Ovsienko [Sun, 17 Nov 2019 22:24:14 +0000 (22:24 +0000)] 
add the usual sections for the next release

10 months agolet mktemp choose the temporary directory
Denis Ovsienko [Sun, 17 Nov 2019 22:13:35 +0000 (22:13 +0000)] 
let mktemp choose the temporary directory

10 months agodrop the props for PHPUnit 4 and 5
Denis Ovsienko [Sun, 17 Nov 2019 22:12:07 +0000 (22:12 +0000)] 
drop the props for PHPUnit 4 and 5

10 months agoTravis CI: use Ubuntu 18.04 and PHP 7.[123]
Denis Ovsienko [Sun, 17 Nov 2019 21:45:20 +0000 (21:45 +0000)] 
Travis CI: use Ubuntu 18.04 and PHP 7.[123]

At the time of writing PHP supports only the following versions:
* 7.1 (old stable)
* 7.2 (old stable)
* 7.3 (current stable)

This list is likely to change once PHP 7.4 is available, which seems to
be coming.

Also PHPUnit supports only the following versions:
* 7 (soon to be retired), which requires PHP 7.1
* 8, which requires PHP 7.2+

In Travis CI Ubuntu 18.04 comes with PHPUnit 8 by default, and supports
only PHP versions 7.1, 7.2 and 7.3. Switch the master branch to 18.04 to
make it more straightforward to rewrite (see commit f81030a) the tests
for PHPUnit 8.

Leave the maintenance-0.21.x branch on Ubuntu 16.04 with its unsupported
versions of PHP and PHPUnit.

10 months ago0.21.4: cut the release maintenance-0.21.x RackTables-0.21.4
Denis Ovsienko [Sun, 17 Nov 2019 20:17:33 +0000 (20:17 +0000)] 
0.21.4: cut the release

10 months agodictionary: add a few recent Linux releases
Denis Ovsienko [Sun, 17 Nov 2019 19:17:00 +0000 (19:17 +0000)] 
dictionary: add a few recent Linux releases

[skip ci]

10 months agoTravis CI: specify Ubuntu 16.04 explicitly
Denis Ovsienko [Sun, 17 Nov 2019 18:52:37 +0000 (18:52 +0000)] 
Travis CI: specify Ubuntu 16.04 explicitly

At this time Travis CI defaults to Ubuntu 16.04, which has PHP versions
5.6, 7.0, 7.1, 7.2 and 7.3. On request it can also provide Ubuntu 18.04,
which has PHP versions 7.1, 7.2 and 7.3. Before Ubuntu 18.04 becomes the
default, nail 16.04 down in .travis.yml to avoid surprise test failures.

10 months agoupgrade CodeMirror from 5.49.0 to 5.49.2
Denis Ovsienko [Sun, 17 Nov 2019 18:22:22 +0000 (18:22 +0000)] 
upgrade CodeMirror from 5.49.0 to 5.49.2

[skip ci]

10 months agoTravis CI: bump PHPUnit 7 version up
Denis Ovsienko [Mon, 4 Nov 2019 22:50:41 +0000 (22:50 +0000)] 
Travis CI: bump PHPUnit 7 version up

11 months agoupgrade CodeMirror from 5.48.2 to 5.49.0
Denis Ovsienko [Tue, 15 Oct 2019 19:15:34 +0000 (20:15 +0100)] 
upgrade CodeMirror from 5.48.2 to 5.49.0

[skip ci]

12 months agoclarify the previous commit
Denis Ovsienko [Sun, 15 Sep 2019 14:30:32 +0000 (15:30 +0100)] 
clarify the previous commit

[skip ci]

12 months agoAdd snmp syncing support for Arista DCS-7050SX-64 (#264)
Denis Ovsienko [Sun, 15 Sep 2019 14:20:04 +0000 (15:20 +0100)] 
Add snmp syncing support for Arista DCS-7050SX-64 (#264)

In addition, this adds a new processor called 'arista-any-QSFP+' which should be
able to get interfaces named like the following:

Ethernet49/1
Ethernet49/2
Ethernet49/3
Ethernet49/4
Ethernet50/1
...

12 months agoTravis CI: fix the build after Ubuntu upgrade
Denis Ovsienko [Sun, 15 Sep 2019 13:08:16 +0000 (14:08 +0100)] 
Travis CI: fix the build after Ubuntu upgrade

Travis CI had changed the default Ubuntu version from 14.04 to 16.04,
which had broken the following jobs:
* PHP 5.5 (because Travis does not supply a PHP 5.5 phpenv archive for
  Ubuntu 16.04)
* PHP 7.0 (because PHPUnit was upgraded from 6.4.3 to 7.5.0)
* PHP 7.1 (because PHPUnit was upgraded from 6.4.3 to 8.0.4)

Complete the change started in commit b3a99c9 and specify the latest
PHPUnit 6 for the PHP 7.0 job and the latest PHPUnit 7 for the PHP 7.1
job. Bump PHP 7.2 and 7.3 jobs to the latest PHPUnit 7 too. Remove PHP
5.5 from the build matrix.

12 months agoAdd snmp syncing support for Arista DCS-7050SX-64 264/head
Lance Albertson [Fri, 6 Sep 2019 22:49:54 +0000 (15:49 -0700)] 
Add snmp syncing support for Arista DCS-7050SX-64

In addition, this adds a new processor called 'arista-any-QSFP+' which should be
able to get interfaces named like the following:

Ethernet49/1
Ethernet49/2
Ethernet49/3
Ethernet49/4
Ethernet50/1
...

13 months agouse vertical writing mode in the 802.1Q report
Denis Ovsienko [Wed, 21 Aug 2019 21:43:41 +0000 (22:43 +0100)] 
use vertical writing mode in the 802.1Q report

It used to be inconvenient to view the domain/VLAN matrix on setups with
many VLAN domains. I tried to switch the domain THs to vertical mode
about 7 years ago, but it didn't work well at that time. Nowadays it is
just a matter of a CSS property, it turns out.

* pi.css
* render8021QReport()

[skip ci]

13 months agoupgrade CodeMirror from 5.46.0 to 5.48.2
Denis Ovsienko [Sun, 4 Aug 2019 20:03:54 +0000 (21:03 +0100)] 
upgrade CodeMirror from 5.46.0 to 5.48.2

[skip ci]

15 months agoamend SQL to work on MySQL 8 (Mantis#1909)
Arkadi Colson [Wed, 19 Jun 2019 14:22:12 +0000 (15:22 +0100)] 
amend SQL to work on MySQL 8 (Mantis#1909)

ROW is a MySQL 8 keyword.

15 months agoadd sections for 0.21.4
Denis Ovsienko [Wed, 19 Jun 2019 14:12:30 +0000 (15:12 +0100)] 
add sections for 0.21.4

[skip ci]

15 months agoTravis CI: update custom PHPUnit from 7.5.7 to .12
Denis Ovsienko [Thu, 13 Jun 2019 08:17:57 +0000 (09:17 +0100)] 
Travis CI: update custom PHPUnit from 7.5.7 to .12

Reduce hard-coding and make the .phar download conditional while at it.

15 months ago0.21.3: cut the release RackTables-0.21.3
Denis Ovsienko [Wed, 12 Jun 2019 14:12:37 +0000 (15:12 +0100)] 
0.21.3: cut the release

15 months agodictionary: add recent Fedora versions
Denis Ovsienko [Wed, 12 Jun 2019 11:46:32 +0000 (12:46 +0100)] 
dictionary: add recent Fedora versions

[skip ci]

15 months agofix an XSS issue in an error message
Denis Ovsienko [Tue, 11 Jun 2019 14:42:16 +0000 (15:42 +0100)] 
fix an XSS issue in an error message

The issue was reported by Diego Di Nardo.

16 months agoQuick fix of formatting. 258/head
MichaelTiernan [Tue, 21 May 2019 17:46:54 +0000 (13:46 -0400)] 
Quick fix of formatting.

16 months agofix hook integration in Cacti and Munin pligins
Denis Ovsienko [Fri, 10 May 2019 11:45:29 +0000 (12:45 +0100)] 
fix hook integration in Cacti and Munin pligins

Commit 011df35 introduced this issue. With "module=image" and either of
the plugins enabled RackTables failed to fail when "img" was set to an
invalid value. This was because the plugins' extension functions always
return TRUE to dispatchImageRequest(), which concluded the work was
always done and thus never raised the default exception. Make the return
in the plugins conditional to fix that.

16 months agoauthorize8021QChangeRequests(): amend PHP array syntax
Denis Ovsienko [Sat, 4 May 2019 21:04:09 +0000 (22:04 +0100)] 
authorize8021QChangeRequests(): amend PHP array syntax

See Mantis#1905. Although support for PHP 5.3 is not a goal, the rest of
PHP code uses traditional array syntax, so let's make it consistent.

17 months agoadd a log entry limit to the object page (Mantis#769)
Denis Ovsienko [Fri, 26 Apr 2019 03:54:00 +0000 (04:54 +0100)] 
add a log entry limit to the object page (Mantis#769)

* getConfigDefaults(): add OBJECTLOG_PREVIEW_ENTRIES
* install.php: idem
* upgrade.php: idem
* renderObject(): use the option to limit the amount of entries

17 months agoupgrade CodeMirror from 5.45.0 to 5.46.0
Denis Ovsienko [Wed, 24 Apr 2019 07:58:45 +0000 (08:58 +0100)] 
upgrade CodeMirror from 5.45.0 to 5.46.0

[skip ci]

17 months agoadd sections for 0.21.3
Denis Ovsienko [Sat, 30 Mar 2019 15:27:17 +0000 (15:27 +0000)] 
add sections for 0.21.3

17 months agodictionary: update OpenWrt entries
Denis Ovsienko [Sat, 30 Mar 2019 15:07:59 +0000 (15:07 +0000)] 
dictionary: update OpenWrt entries

17 months agoupdateObjectAllocation(): fix two PHP messages
Denis Ovsienko [Mon, 1 Apr 2019 08:48:47 +0000 (09:48 +0100)] 
updateObjectAllocation(): fix two PHP messages

Saving an empty working copy would result in the following:

PHP Notice:  Undefined index: rackmulti in ophandlers.php on line 1225
PHP Warning:  Invalid argument supplied for foreach() in ophandlers.php
on line 1225

[skip ci]

18 months ago0.21.2: cut the release RackTables-0.21.2
Denis Ovsienko [Mon, 25 Mar 2019 14:53:51 +0000 (14:53 +0000)] 
0.21.2: cut the release

18 months agoupdate COPYING for 2019
Denis Ovsienko [Mon, 25 Mar 2019 14:26:58 +0000 (14:26 +0000)] 
update COPYING for 2019

[skip ci]

18 months agouse PHPUnit 7.5.7 instead of 8
Denis Ovsienko [Thu, 21 Mar 2019 21:58:08 +0000 (21:58 +0000)] 
use PHPUnit 7.5.7 instead of 8

Run all tests on all PHP versions again.

18 months agoenable minimal CI testing of PHP 7.3
Denis Ovsienko [Thu, 21 Mar 2019 00:10:43 +0000 (00:10 +0000)] 
enable minimal CI testing of PHP 7.3

18 months agofix warnings specific to PHP 7.3
Denis Ovsienko [Thu, 21 Mar 2019 00:09:00 +0000 (00:09 +0000)] 
fix warnings specific to PHP 7.3

PHP Warning:  "continue" targeting switch is equivalent to "break". Did
you mean to use "continue 2"?

* jun10ReadInterfaceStatus()
* addMultiPorts()
* addRealServers()

18 months agoupgrade CodeMirror from 5.43.0 to 5.45.0
Denis Ovsienko [Wed, 20 Mar 2019 23:30:51 +0000 (23:30 +0000)] 
upgrade CodeMirror from 5.43.0 to 5.45.0

[skip ci]

18 months agoadd missing quotes to shell scripts
Denis Ovsienko [Thu, 7 Mar 2019 12:28:01 +0000 (12:28 +0000)] 
add missing quotes to shell scripts

Issue spotted by Mark Brugnoli-Vinten.

19 months agospell product numbers for older HP switch models
Denis Ovsienko [Wed, 20 Feb 2019 00:18:33 +0000 (00:18 +0000)] 
spell product numbers for older HP switch models

[skip ci]

19 months agofixup the previous commit
Denis Ovsienko [Wed, 20 Feb 2019 00:18:07 +0000 (00:18 +0000)] 
fixup the previous commit

[skip ci]

19 months agoadd SNMP support for HP Switches (GH #252)
Sergey Rychka [Wed, 20 Feb 2019 00:01:52 +0000 (03:01 +0300)] 
add SNMP support for HP Switches (GH #252)

add SNMP support for Hp Procurve 5406zl  (Mantis#1485)
add SNMP support for HP A5120-24G (Mantis#1257)
add SNMP support for HP V1910-48G Switch JE009A (Mantis#1193)
add SNMP support for HP Procurve 2900 (Mantis#689)

19 months agogit-commit: remove unnecessary backticks
Denis Ovsienko [Mon, 18 Feb 2019 21:38:58 +0000 (21:38 +0000)] 
git-commit: remove unnecessary backticks

[skip ci]

19 months agogit-commit: make a few variables readonly
Denis Ovsienko [Mon, 18 Feb 2019 21:35:56 +0000 (21:35 +0000)] 
git-commit: make a few variables readonly

[skip ci]

19 months agotests: disregard PHPUnit 8 for now
Denis Ovsienko [Mon, 18 Feb 2019 16:12:20 +0000 (16:12 +0000)] 
tests: disregard PHPUnit 8 for now

In Travis CI PHP 7.2 now comes with PHPUnit 8, which seems to require
rewriting the tests in a way that is not compatible with older PHPUnit
versions. Introduce SKIP_PHPUNIT into the Travis CI matrix to avoid
running PHPUnit 8 on PHP 7.2 until RackTables code is ready (and
potentially to prevent running older PHPUnit versions on older PHP
versions if the switch happens).

19 months agofixup the previous commits
Denis Ovsienko [Thu, 31 Jan 2019 23:50:30 +0000 (23:50 +0000)] 
fixup the previous commits

19 months agoUpdate snmp.php 251/head
Sergey Rychka [Thu, 31 Jan 2019 13:20:17 +0000 (16:20 +0300)] 
Update snmp.php

add SNMP support for Cisco Catalyst 3850-48T (Mantis#1169 and Mantis#1423)
add SNMP support for Cisco 871 (Mantis#1355)
add SNMP support for Cisco Catalyst Model WS-C3850-24T (Mantis#1701)
add SNMP support for Cisco Nexus 3064T (Mantis#1697)

19 months agoUpdate dictionary.php
Sergey Rychka [Thu, 31 Jan 2019 13:11:03 +0000 (16:11 +0300)] 
Update dictionary.php

add SNMP support for Cisco Catalyst 3850-48T (Mantis#1169 and Mantis#1423)
add SNMP support for Cisco 871 (Mantis#1355)
add SNMP support for Cisco Catalyst Model WS-C3850-24T (Mantis#1701)
add SNMP support for Cisco Nexus 3064T (Mantis#1697)

20 months agofunction ios15ShortenIfName_real added to handle port-channel interfaces names correc... 247/head
Vasilii Shashkov [Wed, 23 Jan 2019 06:04:08 +0000 (13:04 +0700)] 
function ios15ShortenIfName_real added to handle port-channel interfaces names correctly - ios15 does not support shorten "po" interface name in cli view

20 months agoupgrade CodeMirror from 5.42.2 to 5.43.0
Denis Ovsienko [Tue, 22 Jan 2019 22:18:07 +0000 (22:18 +0000)] 
upgrade CodeMirror from 5.42.2 to 5.43.0

[skip ci]

20 months agoremove more trailing spaces
Denis Ovsienko [Tue, 22 Jan 2019 22:14:43 +0000 (22:14 +0000)] 
remove more trailing spaces

* renderRackspace()
* snmp.php
* GetChildrenListTest.php
* LinkTriggerTest::setUpBeforeClass()
* StringInsertHrefsTest::setUpBeforeClass()

[skip ci]

20 months agoios15ReadLLDPStatus(): add a break for consistency
Denis Ovsienko [Tue, 22 Jan 2019 22:04:31 +0000 (22:04 +0000)] 
ios15ReadLLDPStatus(): add a break for consistency

[skip ci]

20 months agofixup more code style
Denis Ovsienko [Tue, 22 Jan 2019 22:01:31 +0000 (22:01 +0000)] 
fixup more code style

Put spacing right and do not use empty() to test for an empty string.

* hpprocurveN1178ReadLLDPStatus()
* hpprocurveN1178ReadInterfaceStatus()
* hpprocurveN1178ReadMacList()
* hpprocurveN1178Read8021QConfig()
* hpprocurveN1178TranslatePushQueue()

[skip ci]

20 months agofixup some code style
Denis Ovsienko [Tue, 22 Jan 2019 21:32:21 +0000 (21:32 +0000)] 
fixup some code style

Remove excess braces, put indentation right and simplify a few if's.

* hpprocurveN1178ReadLLDPStatus()
* hpprocurveN1178ReadInterfaceStatus()
* hpprocurveN1178ReadMacList()
* hpprocurveN1178Read8021QConfig()
* hpprocurveN1178TranslatePushQueue()

[skip ci]

20 months agogit-commit: say add/update in the default message
Denis Ovsienko [Tue, 22 Jan 2019 15:18:33 +0000 (15:18 +0000)] 
git-commit: say add/update in the default message

The script used to log "update <filename>" regardless if it was a new
file or a change to an existing file. To make it easier to follow the
history, have it log "add <filename>" in the former case. Replace a
long if() wrapper with an early return while at it.

[skip ci]

20 months agoUpdate regexp in func hpprocurveN1178Read8021QConfig to match Trk interfaces on HP...
igloo777 [Mon, 21 Jan 2019 14:24:12 +0000 (21:24 +0700)] 
Update regexp in func hpprocurveN1178Read8021QConfig to match Trk interfaces on HP Procurve (#245)

20 months agofixup the previous commit
Denis Ovsienko [Sun, 20 Jan 2019 00:49:31 +0000 (00:49 +0000)] 
fixup the previous commit

[skip ci]

20 months agoadd SNMP support for HP switches (GH #243)
Sergey Rychka [Sun, 20 Jan 2019 00:36:59 +0000 (03:36 +0300)] 
add SNMP support for HP switches (GH #243)

add SNMP support for HP 1810-24G (J9450A) (Mantis#1379)
add SNMP support for HP 1810-8G (J9449A) (Mantis#1377)
add SNMP support for HP 1810-24G v2 (J9803A) (Mantis#1285)

20 months agogit-commit: clarify the usage for -a and -d
Denis Ovsienko [Sat, 19 Jan 2019 19:05:11 +0000 (19:05 +0000)] 
git-commit: clarify the usage for -a and -d

[skip ci]

20 months agofixed typo for breed io15 in function queryTerminal
Vasilii Shashkov [Tue, 15 Jan 2019 07:50:30 +0000 (14:50 +0700)] 
fixed typo for breed io15 in function queryTerminal

20 months agotests: fixup the previous commit
Denis Ovsienko [Mon, 14 Jan 2019 22:29:21 +0000 (22:29 +0000)] 
tests: fixup the previous commit

20 months agotests: make the express test sequence safer
Denis Ovsienko [Mon, 14 Jan 2019 18:02:03 +0000 (18:02 +0000)] 
tests: make the express test sequence safer

20 months agogit-commit: try to clean up on a commit failure
Denis Ovsienko [Sun, 13 Jan 2019 22:02:58 +0000 (22:02 +0000)] 
git-commit: try to clean up on a commit failure

[skip ci]

20 months agogit-commit: factor print_error() out
Denis Ovsienko [Sun, 13 Jan 2019 20:46:49 +0000 (20:46 +0000)] 
git-commit: factor print_error() out

[skip ci]

20 months agogit-commit: add a check for FILEPATH
Denis Ovsienko [Sun, 13 Jan 2019 20:32:02 +0000 (20:32 +0000)] 
git-commit: add a check for FILEPATH

Test that the file is not outside of the repository directory. While at
it, move the non-empty check into git_commit_or_exit() as it actually
belongs there.

[skip ci]

20 months agogit-commit: add support for -M (replace|append)
Denis Ovsienko [Sun, 13 Jan 2019 19:25:01 +0000 (19:25 +0000)] 
git-commit: add support for -M (replace|append)

[skip ci]

20 months agogit-commit: fixup the help text for -u
Denis Ovsienko [Sun, 13 Jan 2019 00:33:56 +0000 (00:33 +0000)] 
git-commit: fixup the help text for -u

[skip ci]

20 months agogit-commit: print the usage text on -h only
Denis Ovsienko [Thu, 10 Jan 2019 23:27:01 +0000 (23:27 +0000)] 
git-commit: print the usage text on -h only

On an option error instead of printing the full text only suggest the -h
option as that is more appropriate for stderr.

[skip ci]

20 months agogit-commit: fixup issues from previous commits
Denis Ovsienko [Thu, 10 Jan 2019 23:03:03 +0000 (23:03 +0000)] 
git-commit: fixup issues from previous commits

[skip ci]

20 months agoupgrade CodeMirror from 5.41.0 to 5.42.2
Denis Ovsienko [Thu, 10 Jan 2019 22:17:23 +0000 (22:17 +0000)] 
upgrade CodeMirror from 5.41.0 to 5.42.2

[skip ci]