fixup the previous commit
authorDenis Ovsienko <denis@ovsienko.info>
Mon, 19 Nov 2018 18:14:46 +0000 (18:14 +0000)
committerDenis Ovsienko <denis@ovsienko.info>
Mon, 19 Nov 2018 19:03:56 +0000 (19:03 +0000)
commit70d39d4a17bcf1335ac8bdea032d2ffeb587cb3b
treee6098eadaaac75a6b8763f0fff2881988f14b3e0
parent2308576ab1c835f2d39b79f1f5b457c8faa1a9b9
fixup the previous commit

Move RE_STATIC_URI from solutions.php to functions.php and address
assorted non-critical issues:

* isUri(): use the same regexp as the chrome module does (update the
  tests respectively)
* addPageHeader(): a new helper function with the common code
* addJSExternal(): simplify by using the above function
* addJSInternal(): idem
* addJSText(): idem
* addCSSExternal(): idem
* addCSSInternal(): idem
* addCSSText(): idem
* checkColumnOfRadios8021Q(): update to make a clean call to addJSText()
* renderRackCodeViewer(): idem
* renderRackCodeEditor(): idem
* addParentNodeOptionsJS(): idem
* getOptionTree(): idem
* renderLocationFilterPortlet(): idem

Put some lettercase and punctuation right and add some missing comments
while at it.
README.md
tests/PureFunctionTest.php
wwwroot/inc/functions.php
wwwroot/inc/init.php
wwwroot/inc/interface-8021q.php
wwwroot/inc/interface-config.php
wwwroot/inc/interface-lib.php
wwwroot/inc/interface.php
wwwroot/inc/solutions.php
wwwroot/inc/upgrade.php