use "&&" and "||" instead of "and" and "or"
authorDenis Ovsienko <denis@ovsienko.info>
Wed, 23 Mar 2016 21:56:32 +0000 (21:56 +0000)
committerDenis Ovsienko <denis@ovsienko.info>
Wed, 23 Mar 2016 21:58:04 +0000 (21:58 +0000)
commit55eefced45a6ee07e06bc71a52d64f07893f5ca9
tree5b0bf26d66b17ff6a90ce5b023a4215a58de4557
parent1ee3a14c44063d735616726c0be1714c285e82ca
use "&&" and "||" instead of "and" and "or"

This change prevents unexpected side effects, that, for instance, used
to require two workarounds in iptree_markup_collapsion() and one in
transformRequestData(). The root cause of the problem is that "and" and
"or" are standalone operators: though their associativity is the same as
that of "&&" and "||", the order of precedence is not just different but
is lower than that of "=". The code style article now explains this.

* syncdomain.php
* getNetUsageAJAX()
* authenticate()
* permitted()
* gotClearanceForTagChain()
* authenticated_via_ldap()
* queryLDAPServer()
* RackCodeParser::accept()
* RackCodeParser::un_expr()
* checkAutotagName()
* findCtxModWarnings()
* listCells()
* fillNetKids()
* amplifyCell()
* commitLinkEntities()
* commitUpdateEntityLink()
* updateAddress()
* generateEntityAutoTags()
* createIPv4Prefix()
* newPortForwarding()
* getDomainVLANs()
* getDomainVLANList()
* upd8021QPort()
* setConfigVar()
* setUserConfigVar()
* xos12ReadLLDPStatus()
* xos12ReadInterfaceStatus()
* vrpReadLLDPStatus()
* ftos8ReadLLDPStatus()
* eos4ReadLLDPStatus()
* ros11ReadLLDPStatus()
* jun10TranslatePushQueue()
* jun10Read8021QConfig()
* ftos8ReadInterfaceStatus()
* eos4ReadInterfaceStatus()
* ucsReadInventory()
* isInnoDBSupported()
* platform_is_ok()
* stringTrace()
* assertUIntArg()
* assertStringArg()
* assertBoolArg()
* genericAssertion()
* rectHeight()
* highlightObject()
* ip4_mask()
* ip6_mask()
* l2addressForDatabase()
* sortTokenize()
* pokeNode()
* peekNode()
* addTraceToNodes()
* redirectIfNecessary()
* getObjectiveTagTree()
* getCellFilter()
* IPNetworkCmp()
* iptree_fill()
* ip_next()
* ip_prev()
* treeApplyFunc()
* getTerminalNetworks()
* iptree_markup_collapsion()
* getPortListPrefs()
* getUnlinkedPortTypeOptions()
* groupIntsToRanges()
* array_values_same()
* buildVLANFilter()
* matchVLANFilter()
* generate8021QDeployOps()
* filter8021QChangeRequests()
* getEmployedVlans()
* get8021QSyncOptions()
* exec8021QDeploy()
* saveDownlinksReverb()
* initiateUplinksReverb()
* recalc8021QPorts()
* authorize8021QChangeRequests()
* compareDecomposedPortNames()
* searchEntitiesByText()
* buildSearchRedirectURL()
* setMessage()
* isEthernetPort()
* getConfigVar()
* getObjectTypeChangeOptions()
* apply8021qChangeRequest()
* fillIPNetsCorrelation()
* fillIPSpareListBstr()
* isIPNetworkEmpty()
* listConstraint()
* checkTypeAndAttribute()
* init.php
* install.php
* not_already_installed()
* init_config()
* get_process_owner()
* check_config_access()
* init_database_dynamic()
* render8021QOrderForm()
* renderVLANDomainListEditor()
* renderVLANDomainVLANList()
* renderObject8021QPorts()
* getAccessPortControlCode()
* renderTrunkPortControls()
* renderVLANInfo()
* renderObject8021QSync()
* renderObject8021QSyncPreview()
* renderConfigMainpage()
* renderTagRowForEditor()
* printNiftySelect()
* transformRequestData()
* getRenderedIPv4NetCapacity()
* serializeTags()
* printTagTRs()
* renderEntitySummary()
* niftyString()
* showLogoutURL()
* renderRackspace()
* renderRow()
* printObjectDetailsForRenderRack()
* renderEditRackForm()
* renderObject()
* showMessageOrError()
* renderRackSpaceForObject()
* renderIPSpaceRecords()
* renderIPSpace()
* renderIPNetwork()
* renderIPAddress()
* renderIPAddressProperties()
* renderNATv4ForObject()
* renderLocationPage()
* renderEditLocationForm()
* renderLivePTR()
* buildTagCheckboxRows()
* renderCellFilterPortlet()
* renderFile()
* renderFilesPortlet()
* printIPNetInfoTDs()
* renderCell()
* getFilePreviewCode()
* renderDiscoveredNeighbors()
* switchportInfoJS()
* addIPAllocation()
* processGridForm()
* updateObjectAttributes()
* addLotOfObjects()
* save8021QPorts()
* updVSTRule()
* importDPData()
* cleanupUCS()
* getOpspec()
* buildOpspecColumns()
* findSparePorts()
* handlePopupPortLink()
* detectDeviceBreed()
* prepareRealServersTable()
* SLBTriplet::getTriplets()
* MacroParser::addMacro()
* addRStoRSPool()
* commitUpdateRS()
* doSwitchSNMPmining()
* createTrueColorOrThrow()
* renderProgressBar4Image()
* renderImagePreview()
* proxyStaticURI()
* trigger_liveports()
* trigger_object_8021qorder()
* trigger_8021q_configured()
* trigger_anyDP()
* triggerCactiGraphs()
* triggerMuninGraphs()
* getDBUpgradePath()
* renderUpgraderHTML()
* index.php
25 files changed:
scripts/syncdomain.php
wwwroot/inc/ajax-interface.php
wwwroot/inc/auth.php
wwwroot/inc/code.php
wwwroot/inc/database.php
wwwroot/inc/deviceconfig.php
wwwroot/inc/dictionary.php
wwwroot/inc/exceptions.php
wwwroot/inc/functions.php
wwwroot/inc/init.php
wwwroot/inc/install.php
wwwroot/inc/interface-8021q.php
wwwroot/inc/interface-config.php
wwwroot/inc/interface-lib.php
wwwroot/inc/interface.php
wwwroot/inc/ophandlers.php
wwwroot/inc/popup.php
wwwroot/inc/remote.php
wwwroot/inc/slb-interface.php
wwwroot/inc/slb.php
wwwroot/inc/snmp.php
wwwroot/inc/solutions.php
wwwroot/inc/triggers.php
wwwroot/inc/upgrade.php
wwwroot/index.php