racktables-incomplete-works
5 years agoUpdate auth.php with LDAP option to specify port
Michał Sochoń [Mon, 31 Mar 2014 19:00:19 +0000 (21:00 +0200)] 
Update auth.php with LDAP option to specify port

We use Zentyal which used different port for LDAP read only queries, by default on port 390.

Below example configrarion, hope someone will find it helpful someday. Remember to adjust to your needs.

$LDAP_options = array
(
'server' => 'zentyal-dc.example.com',
'port' => 390,
'domain' => '',
'search_attr' => 'uid',
'search_dn' => 'dc=dir,dc=example,dc=com',
 // The following credentials will be used when searching for the user's DN:
'search_bind_rdn' => 'cn=zentyalro,dc=dir,dc=xstream,dc=dk',
'search_bind_password' => 'enter_pass_here',
'displayname_attrs' => 'cn',
'options' => array (LDAP_OPT_PROTOCOL_VERSION => 3),
'use_tls' => 0,         // 0 == don't attempt, 1 == attempt, 2 == require
);

5 years agoFix UI reset after MGMT_PROTOS change in 0.20.6
Alex Brett [Fri, 28 Mar 2014 12:43:39 +0000 (12:43 +0000)] 
Fix UI reset after MGMT_PROTOS change in 0.20.6

In 0.20.6 TELNET_OBJS_LISTSRC, SSH_OBJS_LISTSRC, and RDP_OBJS_LISTSRC
were replaced with a single MGMT_PROTOS option, but the UI reset code
was not updated and so still attempted to reset the objects which no
longer existed...

5 years agoimprove previous commit: also fix locations
Denis Ovsienko [Wed, 26 Mar 2014 13:28:00 +0000 (17:28 +0400)] 
improve previous commit: also fix locations

5 years agobugfix: properly format comment text for racks
Denis Ovsienko [Wed, 26 Mar 2014 13:05:54 +0000 (17:05 +0400)] 
bugfix: properly format comment text for racks

renderRackInfoPortlet(): print [multi-line] comment inside respective
  DIV, not as plain text.

5 years agoomit password hash values from HTML
Denis Ovsienko [Thu, 20 Mar 2014 14:10:23 +0000 (18:10 +0400)] 
omit password hash values from HTML

The local user accounts management form used to use password hash value
to indicate that there is no change to the password. Stephan Rickauer
points that exposing the hash value isn't good with the rainbow tables
attack in mind. Use an empty string for that purpose instead.

* renderUserListEditor()
* updateUser()

5 years agoshortenIfName: don't lowercase "AC-in" port
Alexey Andriyanov [Tue, 4 Mar 2014 14:08:09 +0000 (18:08 +0400)] 
shortenIfName: don't lowercase "AC-in" port

6 years ago0.20.7: cut the release
Alexey Andriyanov [Mon, 3 Mar 2014 13:14:14 +0000 (17:14 +0400)] 
0.20.7: cut the release

6 years agoadd Cisco Wireless Controller
Aleksandr Balezin [Thu, 27 Feb 2014 17:09:47 +0000 (21:09 +0400)] 
add Cisco Wireless Controller

6 years agomention the minimum PHP version in release notes
Denis Ovsienko [Thu, 27 Feb 2014 14:12:36 +0000 (18:12 +0400)] 
mention the minimum PHP version in release notes

6 years agoadd CentOS 5 notes to README
Denis Ovsienko [Thu, 27 Feb 2014 14:00:53 +0000 (18:00 +0400)] 
add CentOS 5 notes to README

6 years agouse array_fetch() in doSwitchSNMPmining()
Denis Ovsienko [Wed, 26 Feb 2014 05:27:30 +0000 (09:27 +0400)] 
use array_fetch() in doSwitchSNMPmining()

6 years agofix Cisco 6509-VE blade orientation (#985)
Aaron Dummer [Tue, 25 Feb 2014 19:18:18 +0000 (11:18 -0800)] 
fix Cisco 6509-VE blade orientation (#985)

6 years agofix some F5 dictionary entries (#987)
Aaron Dummer [Tue, 25 Feb 2014 18:42:45 +0000 (10:42 -0800)] 
fix some F5 dictionary entries (#987)

6 years agoleave secret.php in a safer state upon install
Denis Ovsienko [Tue, 25 Feb 2014 13:21:45 +0000 (17:21 +0400)] 
leave secret.php in a safer state upon install

Force secret.php to be not writable by httpd after it has been written
by the RackTables installer.

6 years agoget_pseudo_file(): use for(), not hardcoding
Denis Ovsienko [Mon, 24 Feb 2014 12:16:34 +0000 (16:16 +0400)] 
get_pseudo_file(): use for(), not hardcoding

6 years agorequire PHP version 5.2.10 or newer
Denis Ovsienko [Mon, 24 Feb 2014 11:41:59 +0000 (15:41 +0400)] 
require PHP version 5.2.10 or newer

PHP releases prior to 5.2.10 (18 June 2009) suffered a bug in ip2long()
(see RackTables bug #1139 and PHP bug #47365), which was fixed in later
releases. Guard the user from triggering it again.

6 years agoapply RackTables-specific changes to CodeMirror
Denis Ovsienko [Wed, 4 Dec 2013 10:30:06 +0000 (14:30 +0400)] 
apply RackTables-specific changes to CodeMirror

6 years agoupgrade CodeMirror from 3.20 to 3.22
Denis Ovsienko [Mon, 24 Feb 2014 08:11:28 +0000 (12:11 +0400)] 
upgrade CodeMirror from 3.20 to 3.22

6 years agorevert to pristine CodeMirror-3.20
Denis Ovsienko [Wed, 4 Dec 2013 10:26:40 +0000 (14:26 +0400)] 
revert to pristine CodeMirror-3.20

6 years agodictionary: list RHEL version 7 (#1177)
Denis Ovsienko [Sat, 22 Feb 2014 20:54:40 +0000 (00:54 +0400)] 
dictionary: list RHEL version 7 (#1177)

6 years agodictionary item for Cisco IOS 15.2
Alexey Andriyanov [Tue, 18 Feb 2014 15:32:49 +0000 (19:32 +0400)] 
dictionary item for Cisco IOS 15.2

6 years agofix copy-paste bugs in some ophandlers
Alexey Andriyanov [Tue, 18 Feb 2014 13:02:10 +0000 (17:02 +0400)] 
fix copy-paste bugs in some ophandlers

updateFile: fix PHP notice for undefined variable
updIPv4RSP: vsconfig was lost when saving

6 years agogetRenderedIPv4NetCapacity: missing key access fix
Alexey Andriyanov [Tue, 18 Feb 2014 12:57:51 +0000 (16:57 +0400)] 
getRenderedIPv4NetCapacity: missing key access fix

missing key dereference was performed when displaying usage for
unallocated IPv4 space

6 years agoqueryLDAPServer: suppress possible PHP notice
Alexey Andriyanov [Tue, 18 Feb 2014 12:57:12 +0000 (16:57 +0400)] 
queryLDAPServer: suppress possible PHP notice

6 years agovrpReadLLDPStatus: vrp85 was not working
Alexey Andriyanov [Fri, 14 Feb 2014 15:19:12 +0000 (19:19 +0400)] 
vrpReadLLDPStatus: vrp85 was not working

Huawei VRP 8.5 has different Port ID type values. Extend the $valid_subtypes
array and also the extracting regexp.

Do trim of every extracted string, because the values have spaces in trail.

6 years agonew dictionary item Cisco 2960X*
Alexey Andriyanov [Mon, 10 Feb 2014 14:01:39 +0000 (18:01 +0400)] 
new dictionary item Cisco 2960X*

6 years agoisInnoDBSupported: fix failed upgrade reentrance
Alexey Andriyanov [Mon, 10 Feb 2014 13:42:32 +0000 (17:42 +0400)] 
isInnoDBSupported: fix failed upgrade reentrance

If the upgrade script failes on creating a trigger
because of binary logging is turned on, it keeps the innodb_test table,
preventing further calls of isInnoDBSupported().

6 years agoFix for http://bugs.racktables.org/view.php?id=837
Thomas Uhde [Tue, 3 Sep 2013 09:49:44 +0000 (11:49 +0200)] 
Fix for http://bugs.racktables.org/view.php?id=837

Bug #837 describes wrong sort-order for objects with polish characters. This should be fixed by using "collate utf8_unicode_ci" on all tables explicitly.

6 years agodisplay rack power consumption (#701)
Alexey Andriyanov [Mon, 10 Feb 2014 10:57:37 +0000 (14:57 +0400)] 
display rack power consumption (#701)

populateRackPower: function that alters $summary
renderRackInfoPortlet: call populateRackPower()

6 years agobugfix: include Zero-U into ['mountedObjects']
Alexey Andriyanov [Mon, 10 Feb 2014 10:53:37 +0000 (14:53 +0400)] 
bugfix: include Zero-U into ['mountedObjects']

amplifyCell: Zero-U-mounted objects were not counted in rack summary

6 years agobutton to fix non-canonical port names (#827)
Alexey Andriyanov [Mon, 10 Feb 2014 09:25:31 +0000 (13:25 +0400)] 
button to fix non-canonical port names (#827)

shortenPortName: a caching wrapper around detectDeviceBreed and shortenIfName
renderObjectPortRow: highlight port name with yellow if it's name is not canonical
renderPortsForObject: idem, display rename link
renameObjectPorts: new ophandler

6 years agospare IPv6 prefixes are limited to nibble boundary
Alexey Andriyanov [Fri, 7 Feb 2014 12:50:44 +0000 (16:50 +0400)] 
spare IPv6 prefixes are limited to nibble boundary

splitNetworkByMask: new library function
iptree_fill: use net's pre-calculated ['spare_ranges'] array
iptree_construct: removed
iptree_embed: removed

6 years agoMerge pull request #54 from gescheit/master
Alexey Andriyanov [Thu, 6 Feb 2014 06:36:55 +0000 (09:36 +0300)] 
Merge pull request #54 from gescheit/master

bugfix: remove class only if tagInput defined

6 years agobugfix: remove class only if tagInput defined
Aleksandr Balezin [Wed, 5 Feb 2014 15:07:38 +0000 (19:07 +0400)] 
bugfix: remove class only if tagInput defined

tagInput variable not used inside forms of single input, only in forms
of multiple select

6 years agoadd dictionary entries
Aaron Dummer [Sat, 1 Feb 2014 21:28:00 +0000 (13:28 -0800)] 
add dictionary entries

6 years agoadd SNMP support for J8692A (#1143)
Aaron Dummer [Sat, 1 Feb 2014 18:49:24 +0000 (10:49 -0800)] 
add SNMP support for J8692A (#1143)

6 years agoadd SNMP support for J9146A (#1143)
Aaron Dummer [Sat, 1 Feb 2014 18:39:50 +0000 (10:39 -0800)] 
add SNMP support for J9146A (#1143)

6 years agoSLB fix: RS server's rsport field was lost
Alexey Andriyanov [Tue, 28 Jan 2014 13:25:04 +0000 (17:25 +0400)] 
SLB fix: RS server's rsport field was lost

generateVSSection changed

6 years agofix ip4_parse, ip6_parse
Alexey Andriyanov [Tue, 28 Jan 2014 09:34:30 +0000 (13:34 +0400)] 
fix ip4_parse, ip6_parse

If inet_pton() supports IPv6, it is possible that ip4_parse('::')
will return 16-byte binary address.

6 years agonew 'point2point' IP alloc type
Alexey Andriyanov [Mon, 27 Jan 2014 15:58:43 +0000 (19:58 +0400)] 
new 'point2point' IP alloc type

genericAssertion: new array item 'point2point'
markupIPAddrList: idem
getPtPNeighbors: call to search for ptp peers in the network's addrlist
getRenderedAlloc: display peers near the ptp-typed allocations

6 years agonew library call makeIPAllocLink()
Alexey Andriyanov [Mon, 27 Jan 2014 15:54:48 +0000 (19:54 +0400)] 
new library call makeIPAllocLink()

getRenderedAlloc: use getRenderedAlloc
renderIPv4NetworkAddresses: idem
renderIPv6NetworkAddresses: idem
renderIPAddress: idem
renderIPAddressAllocations: idem

6 years agoclarify object's IP allocations rendering
Alexey Andriyanov [Mon, 27 Jan 2014 15:50:55 +0000 (19:50 +0400)] 
clarify object's IP allocations rendering

'aac' global, '.aac' css class renamed to 'aac-right'
'aac2' global renamed to 'aac-left', corresponding css class created
getRenderedAlloc: fix missing <td> tag in 'td_routed_by' field
renderObject: align th labels by left side
renderFile: remove unused global declarations

6 years agobugfix: is_inet_avail() was broken
Alexey Andriyanov [Mon, 27 Jan 2014 05:14:30 +0000 (09:14 +0400)] 
bugfix: is_inet_avail() was broken

is_inet_avail: fixed and made IPv4-scoped function
is_inet6_avail: split from is_inet_avail, checks for IPv6 support
ip6_format: use is_inet6_avail
ip6_parse: idem
ip_parse: do colon lookup first. Than call ip[46]_parse unconditionally

6 years agobugfix: wrong port order
Alexey Andriyanov [Tue, 21 Jan 2014 13:49:10 +0000 (17:49 +0400)] 
bugfix: wrong port order

compareDecomposedPortNames fixed (see cfb315)

6 years agobugfix: switches stucked in 'disabled' queue
Alexey Andriyanov [Tue, 21 Jan 2014 10:29:29 +0000 (14:29 +0400)] 
bugfix: switches stucked in 'disabled' queue

one of the previous commits broke the queue transition logic in syncdomain.php
Once the switch entered the 'disabled' state, it had no chance to return back
into 'noerror'.

This change fixes the issue

6 years agorenderInterfaceHTML: utilize invalid credentials in the logout link to nullify HTTP...
Aaron Dummer [Sat, 18 Jan 2014 23:17:57 +0000 (15:17 -0800)] 
renderInterfaceHTML: utilize invalid credentials in the logout link to nullify HTTP basic authentication (#1129)

6 years agoallow Rows to have attributes (#1133)
Aaron Dummer [Sat, 18 Jan 2014 19:44:32 +0000 (11:44 -0800)] 
allow Rows to have attributes (#1133)

renderRow: display attributes
renderEditRowForm: new function
renderEditAttrMapForm: stop excluding Rows
updateRow: update attributes

6 years agorenderDepot: objects with problems are colored red (#1137)
Aaron Dummer [Sat, 18 Jan 2014 18:43:31 +0000 (10:43 -0800)] 
renderDepot: objects with problems are colored red (#1137)

6 years agoMerge pull request #53 from gescheit/suggest
Alexey Andriyanov [Fri, 17 Jan 2014 13:46:16 +0000 (17:46 +0400)] 
Merge pull request #53 from gescheit/suggest

Added tag picker with autocompletion

6 years agotags picker: fix the A-tag's style inheriting
Alexey Andriyanov [Fri, 17 Jan 2014 13:43:13 +0000 (17:43 +0400)] 
tags picker: fix the A-tag's style inheriting

6 years agotags picker: fix dynamic CSS issue
Alexey Andriyanov [Fri, 17 Jan 2014 13:42:34 +0000 (17:42 +0400)] 
tags picker: fix dynamic CSS issue

'*' suggest used to create tons of dynamic CSS style each time the star was pressed.
Now there are predefined styles for each level up to 10. So the dynamic_style is removed.

6 years agotags picker release notes
Alexey Andriyanov [Sat, 11 Jan 2014 23:33:44 +0000 (03:33 +0400)] 
tags picker release notes

6 years agofix ponentially harmful foreach => &$ref
Alexey Andriyanov [Sat, 11 Jan 2014 19:37:15 +0000 (23:37 +0400)] 
fix ponentially harmful foreach => &$ref

fixed funcs:
printTagsPickerUl
enableTagsPicker

6 years agoserializeTags: include the tag itself into trace
Alexey Andriyanov [Sat, 11 Jan 2014 19:20:34 +0000 (23:20 +0400)] 
serializeTags: include the tag itself into trace

6 years agoremove stale comments
Denis Ovsienko [Thu, 16 Jan 2014 14:46:00 +0000 (18:46 +0400)] 
remove stale comments

6 years agojustify IAE -> IRAE conversion
Denis Ovsienko [Thu, 16 Jan 2014 14:37:32 +0000 (18:37 +0400)] 
justify IAE -> IRAE conversion

InvalidArgException: remove 3 accessor methods to stop exposing
  unnecessary details, add two class conversion methods
convertToIRAE(): reduce and deprecate
assertDateArg(): switch to InvalidArgException::newIRAE()
assertIPArg(): idem
assertIPv4Arg(): idem
assertIPv6Arg(): idem

6 years agoAPI: applyCellFilter_hook to override cellfilter
Alexey Andriyanov [Thu, 16 Jan 2014 12:00:49 +0000 (16:00 +0400)] 
API: applyCellFilter_hook to override cellfilter

in some cases admin might want to speed-up rendering of filtered depot page
using env-specific assumptions. This change introduces applyCellFilter_hook
that allows to get rid of listCells() call when rendering depot page.

applyCellFilter: new wrapper function that takes $realm and $cellfilter,
calls applyCellFilter_hook and then filterCellList(listCells())
    unless hook returned list.
renderRackspace: use new applyCellFilter
renderRow: idem
renderDepot: idem
renderCellList: idem

6 years agoadd missing escaping to renderFileSummary()
Denis Ovsienko [Thu, 16 Jan 2014 11:26:07 +0000 (15:26 +0400)] 
add missing escaping to renderFileSummary()

6 years agothe 2nd TITLE in getOpLink() was a bug
Denis Ovsienko [Thu, 16 Jan 2014 10:59:29 +0000 (14:59 +0400)] 
the 2nd TITLE in getOpLink() was a bug

6 years agofixup a few non-breaking space entities
Denis Ovsienko [Thu, 16 Jan 2014 10:49:00 +0000 (14:49 +0400)] 
fixup a few non-breaking space entities

6 years agorefine VLAN compound key assertion checks
Denis Ovsienko [Thu, 16 Jan 2014 10:20:19 +0000 (14:20 +0400)] 
refine VLAN compound key assertion checks

Replace "uint-uint" assertion with "uint-vlan" and "uint-vlan1" and make
use of these in respective ophandlers such that these attribute a
malformed VLAN compound key to user's input (InvalidRequestArgException)
rather than an internal error (InvalidArgException).

6 years agorefine some wording in genericAssertion()
Denis Ovsienko [Thu, 16 Jan 2014 10:17:46 +0000 (14:17 +0400)] 
refine some wording in genericAssertion()

6 years agodo HTML escaping on error pages
Denis Ovsienko [Thu, 16 Jan 2014 10:02:40 +0000 (14:02 +0400)] 
do HTML escaping on error pages

Lukas Reschke (via Stephan Rickauer) points that arguments that don't
pass the assertion checks make it to the exception page unescaped.

Move niftyString() to interface-lib.php to make it available in
exceptions.php and modify InvalidArgException::__construct() and
dumpArray() to use it.

6 years agomarkupIPAddrList: highlight duplicate allocs red
Alexey Andriyanov [Thu, 16 Jan 2014 10:44:59 +0000 (14:44 +0400)] 
markupIPAddrList: highlight duplicate allocs red

duplicate allocs of type 'virtual' and 'router' were not highlighted before,
and 'shared' alloc type had no difference to 'virtual'.

6 years agogetCellFilter: call session_commit(), release lock
Alexey Andriyanov [Thu, 16 Jan 2014 09:34:30 +0000 (13:34 +0400)] 
getCellFilter: call session_commit(), release lock

getCellFilter was calling session_start(), but not session_commit().
This leads to lock user's activity in other tabs until depot rendering is finished

6 years agoadd missing keywords to CodeMirror definitions
Denis Ovsienko [Mon, 13 Jan 2014 12:13:03 +0000 (16:13 +0400)] 
add missing keywords to CodeMirror definitions

6 years agotag picker with autocompletion
Aleksandr Balezin [Fri, 13 Dec 2013 14:02:50 +0000 (18:02 +0400)] 
tag picker with autocompletion

This is an UI enhancement.
Instead of showing tons of tags in one page, show only a text input
with suggestion. A user can quickly find necessary tags by typing
some characters of it.

Removed 'Tag' tab from all pages. Now tag assigning is performed on
'Properties' or 'Edit' tabs.

changes:
Removed saveEntityTags(), renderNewEntityTags(), renderEntityTags(),
    renderEntityTagsPortlet() functions.
    'editRange', 'updIPv4RSP' and 'updateFile' ops switched from
    tableHandler()
       to dedicated functions.

6 years agoadd tag-it plugin from github.com/aehlke/tag-it
Aleksandr Balezin [Fri, 13 Dec 2013 13:22:29 +0000 (17:22 +0400)] 
add tag-it plugin from github.com/aehlke/tag-it

6 years agoshow tag trace in tag title
Aleksandr Balezin [Fri, 13 Dec 2013 12:54:39 +0000 (16:54 +0400)] 
show tag trace in tag title

6 years agodraw root tag separator lines in tag tree view
Alexey Andriyanov [Fri, 10 Jan 2014 10:42:25 +0000 (14:42 +0400)] 
draw root tag separator lines in tag tree view

renderTagRowForViewer, renderTagTree changed

6 years agobugfix: invalid url for pix/1x1t.gif
Alexey Andriyanov [Fri, 10 Jan 2014 10:40:57 +0000 (14:40 +0400)] 
bugfix: invalid url for pix/1x1t.gif

renderLocationFilterPortlet changed, use module=chrome proxying

6 years agoremove static NAT translations update from 0.20.6 block, it applies to 0.20.7
Aaron Dummer [Sat, 4 Jan 2014 18:33:45 +0000 (10:33 -0800)] 
remove static NAT translations update from 0.20.6 block, it applies to 0.20.7

6 years agoMerge pull request #47 from MWilkinson/BUG_971_v2
adoom42 [Sat, 4 Jan 2014 18:22:47 +0000 (10:22 -0800)] 
Merge pull request #47 from MWilkinson/BUG_971_v2

Feature add - Static Nat Translations for IPv4 - Bug 971 v2

6 years agoAdditions to patch supplied by Tim Wilkes
MWilkinson [Thu, 21 Nov 2013 07:34:19 +0000 (07:34 +0000)] 
Additions to patch supplied by Tim Wilkes

Final Credit for the pull request to me

Rebased for 0.20.7 and updated coding style on if statements

6 years agoUpdate to add static NAT translations to the IPv4 address space
Tim Wilkes [Tue, 31 Dec 2013 20:39:46 +0000 (12:39 -0800)] 
Update to add static NAT translations to the IPv4 address space
See Bug report #971

6 years agofix syntax error in form validator
Aleksandr Balezin [Fri, 13 Dec 2013 13:13:40 +0000 (17:13 +0400)] 
fix syntax error in form validator

6 years agoshowPathAndSearch: display location tree in object breadcrumbs (#1125)
Aaron Dummer [Tue, 31 Dec 2013 20:39:46 +0000 (12:39 -0800)] 
showPathAndSearch: display location tree in object breadcrumbs (#1125)

6 years agorelax the EntityLink UPDATE trigger and add unit tests to cover valid use cases
Aaron Dummer [Mon, 30 Dec 2013 22:28:50 +0000 (14:28 -0800)] 
relax the EntityLink UPDATE trigger and add unit tests to cover valid use cases

6 years agosome pages would not load because PHP's maximum execution time was exceeded, caused...
Aaron Dummer [Mon, 30 Dec 2013 20:40:41 +0000 (12:40 -0800)] 
some pages would not load because PHP's maximum execution time was exceeded, caused by a circular reference in the location tree (#1123)

add database triggers to the EntityLink table
add unit tests: EntityLinkTriggerTest, ObjectCircularReferenceTest, TagTreeCircularReferenceTest
getObjectContentsList: fix circular reference detection
getLocationChildrenList: new function which mimics getObjectContents list
getTagChildrenList: idem
commitLinkEntities: check for circular references
commitUpdateEntityLink: idem
commitUpdateTag: idem, new function replaces tableHandler call
getLocationTrail: exit at a depth of 20, there is probably a circular reference
renderRackspace: idem, when displaying the location tree
renderTagTreeEditor: add is_assignable hidden field to the 'fallen leaves' portlet, form submission failed even before the tableHandler replacement
renderDataIntegrityReport: report circular references for locations, objects and tags
linkObjects: new ophandler replaces tableHandler
updateTag: idem

6 years agoLinkTriggerTest: adjust code style
Aaron Dummer [Mon, 30 Dec 2013 19:10:08 +0000 (11:10 -0800)] 
LinkTriggerTest: adjust code style

6 years agoStringInsertHrefsTest: setUp and tearDown the fixture once
Aaron Dummer [Thu, 26 Dec 2013 19:22:57 +0000 (11:22 -0800)] 
StringInsertHrefsTest: setUp and tearDown the fixture once

6 years agoLinkTriggerTest: setUp and tearDown the fixture once, instead of before and after...
Aaron Dummer [Thu, 26 Dec 2013 17:35:59 +0000 (09:35 -0800)] 
LinkTriggerTest: setUp and tearDown the fixture once, instead of before and after each test

6 years agoLinkTriggerTest: remove superfluous globals
Aaron Dummer [Wed, 25 Dec 2013 22:48:36 +0000 (14:48 -0800)] 
LinkTriggerTest: remove superfluous globals

6 years agorenderDataIntegrityReport: report on triggers and foreign keys
Aaron Dummer [Wed, 25 Dec 2013 20:56:22 +0000 (12:56 -0800)] 
renderDataIntegrityReport: report on triggers and foreign keys

6 years agoadd SNMP support for AT-GS950/24 (#1105), de-duplicate some code
Aaron Dummer [Sun, 22 Dec 2013 19:49:45 +0000 (11:49 -0800)] 
add SNMP support for AT-GS950/24 (#1105), de-duplicate some code

6 years agoadd SNMP support for HP J4900B (#1107)
Aaron Dummer [Sun, 22 Dec 2013 19:14:14 +0000 (11:14 -0800)] 
add SNMP support for HP J4900B (#1107)

6 years agoadd SNMP support for Cisco WS-C1924 (#1111)
Aaron Dummer [Sun, 22 Dec 2013 18:41:32 +0000 (10:41 -0800)] 
add SNMP support for Cisco WS-C1924 (#1111)

6 years agorenderDepot threw an exception if any objects with an unnamed container existed ...
Aaron Dummer [Sun, 22 Dec 2013 01:22:06 +0000 (17:22 -0800)] 
renderDepot threw an exception if any objects with an unnamed container existed (#1115)
formatObjectDisplayedName: new function that returns "[ObjectType]" for nameless objects
setDisplayedName: use formatDisplayedName
getContainerInfo: idem

6 years agoadd database triggers to the Link table
Aaron Dummer [Sat, 21 Dec 2013 19:22:56 +0000 (11:22 -0800)] 
add database triggers to the Link table

6 years agorefine use of "return" in isInnoDBSupported()
Denis Ovsienko [Wed, 18 Dec 2013 15:34:50 +0000 (19:34 +0400)] 
refine use of "return" in isInnoDBSupported()

6 years agocommitUpdateAttrValue: don't make dummy SQL UPDATE
Alexey Andriyanov [Tue, 17 Dec 2013 14:13:45 +0000 (18:13 +0400)] 
commitUpdateAttrValue: don't make dummy SQL UPDATE

6 years agofix bug I've added in syncdomain.php
Alexey Andriyanov [Tue, 17 Dec 2013 14:12:33 +0000 (18:12 +0400)] 
fix bug I've added in syncdomain.php

6 years agoSNMP: list HP J9085A (2610-24)
Sebastian Mogilowski [Mon, 16 Dec 2013 17:04:45 +0000 (21:04 +0400)] 
SNMP: list HP J9085A (2610-24)

6 years agofactor array_fetch() out
Denis Ovsienko [Mon, 16 Dec 2013 16:44:30 +0000 (20:44 +0400)] 
factor array_fetch() out

There is no core function in PHP that would return a default value when
there is no requested index in the array (consider Array.fetch() in
Ruby). Implement and use such function to replace a few ternary
conditionals with a more focused notation.

* array_fetch(): new function
* syncdomain.php: update
* getPrevIDforRack(): idem
* getNextIDforRack(): idem
* formatRealmName(): idem
* get8021QSyncOptions(): idem
* strerror8021Q(): idem
* renderObject8021QPorts(): idem
* renderObject8021QSyncPorts(): idem
* resolve8021QConflicts(): idem
* tableHandler(): idem

6 years agodon't use argument by reference in doubleLink()
Denis Ovsienko [Mon, 16 Dec 2013 16:22:04 +0000 (20:22 +0400)] 
don't use argument by reference in doubleLink()

* doubleLink(): update to distinguish input and output data
* getPrevIDforRack(): use function superposition
* getNextIDforRack(): idem
* getProximateRacks(): idem

6 years agoStringInsertHrefsTest: use a dataProvider for the sample data
Aaron Dummer [Sun, 15 Dec 2013 21:07:25 +0000 (13:07 -0800)] 
StringInsertHrefsTest: use a dataProvider for the sample data

6 years agostring_insert_hrefs: use preg_replace_callback() instead of preg_replace() with the...
Aaron Dummer [Sun, 15 Dec 2013 20:13:13 +0000 (12:13 -0800)] 
string_insert_hrefs: use preg_replace_callback() instead of preg_replace() with the /e modifier (deprecated, causes a warning with PHP 5.5)
StringInsertHrefsTest: unit test to validate string_insert_hrefs

6 years agoacquireLDAPCache: fix recursive function call
Aaron Dummer [Sat, 14 Dec 2013 23:25:17 +0000 (15:25 -0800)] 
acquireLDAPCache: fix recursive function call

6 years agofix some space-indented lines with tabs
Denis Ovsienko [Sat, 14 Dec 2013 14:06:25 +0000 (18:06 +0400)] 
fix some space-indented lines with tabs

6 years agoimprove readability after 7bc5438
Denis Ovsienko [Fri, 13 Dec 2013 16:08:48 +0000 (20:08 +0400)] 
improve readability after 7bc5438

Streamline a number of ?: cases and make use of fetchColumn() where it
fits.

* getIPv4AddressNetworkId()
* fetchIPv4AddressNetworkRow()
* getIPv6AddressNetworkId()
* fetchIPv6AddressNetworkRow()
* objectTypeMayHaveParent()
* loadScript()
* getFileCache()
* findFileByName()
* getUserIDByUsername()
* getVLANSwitchInfo()